Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: shell/application_manager/application_manager.h

Issue 983113002: ApplicationManager: Use callback to get notified on application shutdown. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Rebase after parameters fix Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | shell/application_manager/application_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/application_manager/application_manager.h
diff --git a/shell/application_manager/application_manager.h b/shell/application_manager/application_manager.h
index 8aaf5bd0d5f36606ad8d897a1a00e2ffd7609a46..7805b9f9182e94471513d99c8cfba9bb781af3f2 100644
--- a/shell/application_manager/application_manager.h
+++ b/shell/application_manager/application_manager.h
@@ -36,9 +36,6 @@ class ApplicationManager {
class Delegate {
public:
virtual ~Delegate();
- // Send when the Application holding the handle on the other end of the
- // Shell pipe goes away.
- virtual void OnApplicationError(const GURL& url);
virtual GURL ResolveURL(const GURL& url);
virtual GURL ResolveMappings(const GURL& url);
};
@@ -67,7 +64,8 @@ class ApplicationManager {
void ConnectToApplication(const GURL& application_url,
const GURL& requestor_url,
InterfaceRequest<ServiceProvider> services,
- ServiceProviderPtr exposed_services);
+ ServiceProviderPtr exposed_services,
+ const base::Closure& on_application_end);
template <typename Interface>
inline void ConnectToService(const GURL& application_url,
@@ -145,6 +143,7 @@ class ApplicationManager {
const GURL& requestor_url,
InterfaceRequest<ServiceProvider> services,
ServiceProviderPtr exposed_services,
+ const base::Closure& on_application_end,
const std::vector<std::string>& parameters);
bool ConnectToRunningApplication(const GURL& resolved_url,
@@ -153,24 +152,21 @@ class ApplicationManager {
ServiceProviderPtr* exposed_services);
bool ConnectToApplicationWithLoader(
- const GURL& requested_url,
const GURL& resolved_url,
const GURL& requestor_url,
InterfaceRequest<ServiceProvider>* services,
ServiceProviderPtr* exposed_services,
+ const base::Closure& on_application_end,
const std::vector<std::string>& parameters,
ApplicationLoader* loader);
InterfaceRequest<Application> RegisterShell(
- // The original URL requested by client, before any resolution or
- // redirects.
- // This is mostly useless and should be removed.
- const GURL& original_url,
// The URL after resolution and redirects, including the querystring.
const GURL& resolved_url,
const GURL& requestor_url,
InterfaceRequest<ServiceProvider> services,
ServiceProviderPtr exposed_services,
+ const base::Closure& on_application_end,
const std::vector<std::string>& parameters);
ShellImpl* GetShellImpl(const GURL& url);
@@ -181,10 +177,10 @@ class ApplicationManager {
InterfaceRequest<ServiceProvider> services,
ServiceProviderPtr exposed_services);
- void HandleFetchCallback(const GURL& requested_url,
- const GURL& requestor_url,
+ void HandleFetchCallback(const GURL& requestor_url,
InterfaceRequest<ServiceProvider> services,
ServiceProviderPtr exposed_services,
+ const base::Closure& on_application_end,
const std::vector<std::string>& parameters,
NativeRunner::CleanupBehavior cleanup_behavior,
scoped_ptr<Fetcher> fetcher);
« no previous file with comments | « no previous file | shell/application_manager/application_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698