Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1711)

Unified Diff: shell/application_manager/application_manager.h

Issue 983113002: ApplicationManager: Use callback to get notified on application shutdown. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: shell/application_manager/application_manager.h
diff --git a/shell/application_manager/application_manager.h b/shell/application_manager/application_manager.h
index 38784d734f9d5fe881075a0e632b6866e1596a8f..4e82166f09d2f4e1ffe0672364ed67cbca6e9fef 100644
--- a/shell/application_manager/application_manager.h
+++ b/shell/application_manager/application_manager.h
@@ -35,9 +35,6 @@ class ApplicationManager {
class Delegate {
public:
virtual ~Delegate();
- // Send when the Application holding the handle on the other end of the
- // Shell pipe goes away.
- virtual void OnApplicationError(const GURL& url);
virtual GURL ResolveURL(const GURL& url);
virtual GURL ResolveMappings(const GURL& url);
};
@@ -66,7 +63,8 @@ class ApplicationManager {
void ConnectToApplication(const GURL& application_url,
const GURL& requestor_url,
InterfaceRequest<ServiceProvider> services,
- ServiceProviderPtr exposed_services);
+ ServiceProviderPtr exposed_services,
+ const base::Closure& on_application_end);
template <typename Interface>
inline void ConnectToService(const GURL& application_url,
@@ -144,23 +142,20 @@ class ApplicationManager {
ServiceProviderPtr* exposed_services);
bool ConnectToApplicationWithLoader(
- const GURL& requested_url,
const GURL& resolved_url,
const GURL& requestor_url,
InterfaceRequest<ServiceProvider>* services,
ServiceProviderPtr* exposed_services,
+ const base::Closure& on_application_end,
ApplicationLoader* loader);
InterfaceRequest<Application> RegisterShell(
- // The original URL requested by client, before any resolution or
- // redirects.
- // This is mostly useless and should be removed.
- const GURL& original_url,
// The URL after resolution and redirects, including the querystring.
const GURL& resolved_url,
const GURL& requestor_url,
InterfaceRequest<ServiceProvider> services,
- ServiceProviderPtr exposed_services);
+ ServiceProviderPtr exposed_services,
+ const base::Closure& on_application_end);
ShellImpl* GetShellImpl(const GURL& url);
@@ -170,10 +165,10 @@ class ApplicationManager {
InterfaceRequest<ServiceProvider> services,
ServiceProviderPtr exposed_services);
- void HandleFetchCallback(const GURL& requested_url,
- const GURL& requestor_url,
+ void HandleFetchCallback(const GURL& requestor_url,
InterfaceRequest<ServiceProvider> services,
ServiceProviderPtr exposed_services,
+ const base::Closure& on_application_end,
NativeRunner::CleanupBehavior cleanup_behavior,
scoped_ptr<Fetcher> fetcher);
« no previous file with comments | « no previous file | shell/application_manager/application_manager.cc » ('j') | shell/application_manager/application_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698