minidump/minidump_memory_writer.cc - Issue 983103004: win: fixes for Windows x64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_memory_writer.cc

Issue 983103004: win: fixes for Windows x64 (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: mac Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: minidump/minidump_memory_writer.cc

diff --git a/minidump/minidump_memory_writer.cc b/minidump/minidump_memory_writer.cc

index a65f5989ba8c4a9f6897f5ebc6f4b9b4a403b9fa..606623e453e815144514cb95f91e4df023afbb8b 100644

--- a/minidump/minidump_memory_writer.cc

+++ b/minidump/minidump_memory_writer.cc

@@ -129,7 +129,7 @@ size_t MinidumpMemoryWriter::SizeOfObject() {

return MemoryRangeSize();

}

-bool MinidumpMemoryWriter::WillWriteAtOffsetImpl(off_t offset) {

+bool MinidumpMemoryWriter::WillWriteAtOffsetImpl(FileOffset offset) {

DCHECK_EQ(state(), kStateFrozen);

// There will always be at least one registered descriptor, the one for this