minidump/minidump_file_writer.h - Issue 983103004: win: fixes for Windows x64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_file_writer.h

Issue 983103004: win: fixes for Windows x64 (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: mac Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: minidump/minidump_file_writer.h

diff --git a/minidump/minidump_file_writer.h b/minidump/minidump_file_writer.h

index fed26e1a7353ac2ea784b31161de8a32044a0038..8b738b649009172feedd66068632980b52fb7882 100644

--- a/minidump/minidump_file_writer.h

+++ b/minidump/minidump_file_writer.h

@@ -27,6 +27,7 @@

#include "minidump/minidump_extensions.h"

#include "minidump/minidump_stream_writer.h"

#include "minidump/minidump_writable.h"

+#include "util/file/file_io.h"

#include "util/stdlib/pointer_container.h"

namespace crashpad {

@@ -105,7 +106,7 @@ class MinidumpFileWriter final : public internal::MinidumpWritable {

bool Freeze() override;

size_t SizeOfObject() override;

std::vector<MinidumpWritable*> Children() override;

- bool WillWriteAtOffsetImpl(off_t offset) override;

+ bool WillWriteAtOffsetImpl(FileOffset offset) override;

bool WriteObject(FileWriterInterface* file_writer) override;

private:

« no previous file with comments | « minidump/minidump_exception_writer_test.cc ('k') | minidump/minidump_file_writer.cc » ('j') | no next file with comments »