Source/core/layout/svg/SVGLayoutSupport.cpp - Issue 983103003: Use Length for the stroke-width property in SVGLayoutStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/svg/SVGLayoutSupport.cpp

Issue 983103003: Use Length for the stroke-width property in SVGLayoutStyle (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: lengthSetterForProperty Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/svg/SVGLayoutSupport.cpp

diff --git a/Source/core/layout/svg/SVGLayoutSupport.cpp b/Source/core/layout/svg/SVGLayoutSupport.cpp

index c9c11fe84f29394d932724f66df6fbc5f39f4a52..58520b57dadc2c3925f93ed0e35fb60c2777d37b 100644

--- a/Source/core/layout/svg/SVGLayoutSupport.cpp

+++ b/Source/core/layout/svg/SVGLayoutSupport.cpp

@@ -364,7 +364,7 @@ void SVGLayoutSupport::applyStrokeStyleToContext(GraphicsContext& context, const

const SVGLayoutStyle& svgStyle = style.svgStyle();

SVGLengthContext lengthContext(toSVGElement(object.node()));

- context.setStrokeThickness(svgStyle.strokeWidth()->value(lengthContext));

+ context.setStrokeThickness(lengthContext.valueForLength(svgStyle.strokeWidth()));

context.setLineCap(svgStyle.capStyle());

context.setLineJoin(svgStyle.joinStyle());

context.setMiterLimit(svgStyle.strokeMiterLimit());

@@ -381,7 +381,7 @@ void SVGLayoutSupport::applyStrokeStyleToStrokeData(StrokeData& strokeData, cons

const SVGLayoutStyle& svgStyle = style.svgStyle();

SVGLengthContext lengthContext(toSVGElement(object.node()));

- strokeData.setThickness(svgStyle.strokeWidth()->value(lengthContext));

+ strokeData.setThickness(lengthContext.valueForLength(svgStyle.strokeWidth()));

strokeData.setLineCap(svgStyle.capStyle());

strokeData.setLineJoin(svgStyle.joinStyle());

strokeData.setMiterLimit(svgStyle.strokeMiterLimit());