Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 983083004: Do not allow asan_symbolize.py to fall back to addr2line/atos. (Closed)

Created:
5 years, 9 months ago by earthdok
Modified:
5 years, 9 months ago
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not allow asan_symbolize.py to fall back to addr2line/atos. For performance reasons we want to stick to llvm-symbolizer. This also rolls the third-party asan_symbolize.py to r231492. BUG=415179 TBR=glider@chromium.org NOTRY=true Committed: https://crrev.com/2ee9a8ae1e39433fc8df07c27256963715747bbb Cr-Commit-Position: refs/heads/master@{#319460}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M tools/valgrind/asan/asan_symbolize.py View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/valgrind/asan/third_party/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind/asan/third_party/asan_symbolize.py View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
earthdok
5 years, 9 months ago (2015-03-06 17:11:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983083004/1
5 years, 9 months ago (2015-03-06 17:12:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-06 17:13:30 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2ee9a8ae1e39433fc8df07c27256963715747bbb Cr-Commit-Position: refs/heads/master@{#319460}
5 years, 9 months ago (2015-03-06 17:14:09 UTC) #5
Alexander Potapenko
On 2015/03/06 17:14:09, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
5 years, 9 months ago (2015-03-10 11:14:00 UTC) #6
earthdok
5 years, 9 months ago (2015-03-17 19:17:01 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1017793002/ by earthdok@chromium.org.

The reason for reverting is: Turns out the fall back to addr2line happens
routinely. We need to fix that before proceeding with this change..

Powered by Google App Engine
This is Rietveld 408576698