Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: Source/core/css/resolver/FontBuilder.cpp

Issue 983073002: Make font-size-adjust animatable. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase expectations for bug2886-2.html Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/resolver/AnimatedStyleBuilder.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/resolver/FontBuilder.cpp
diff --git a/Source/core/css/resolver/FontBuilder.cpp b/Source/core/css/resolver/FontBuilder.cpp
index f4ac93595588604e94b3f5118cb37d9e43b2199b..28cebbcf4a2ddf7ff454393fd5d60a4840e8ef1d 100644
--- a/Source/core/css/resolver/FontBuilder.cpp
+++ b/Source/core/css/resolver/FontBuilder.cpp
@@ -335,6 +335,10 @@ void FontBuilder::updateAdjustedSize(FontDescription& fontDescription, const Lay
return;
// We need to create a temporal Font to get xHeight of a primary font.
+ // The aspect value is based on the xHeight of the font for the computed font size,
+ // so we need to reset the adjustment.
+ fontDescription.setAdjustedSize(0);
+
Font font(fontDescription);
font.update(fontSelector);
if (!font.fontMetrics().hasXHeight())
« no previous file with comments | « Source/core/css/resolver/AnimatedStyleBuilder.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698