LayoutTests/animations/interpolation/font-size-adjust-interpolation.html - Issue 983073002: Make font-size-adjust animatable.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/animations/interpolation/font-size-adjust-interpolation.html

Issue 983073002: Make font-size-adjust animatable. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Changed to use fallBackToLegacy in StringKeyframe.cpp Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style type="text/css">

	3 .container {

	4 font-size: 20px;

	5 line-height: 1;

	6 }

	7

	8 @font-face {

	9 font-family : 'testFont';

	10 src : url('../../resources/opensans/OpenSans-Regular.woff') format("woff");

	11 }

	12

	13 .target {

	14 display: inline-block;

	15 font-family: testFont;

	16 }

	17

	18 .replica {

	19 color: green;

	20 margin-right: 30px;

	21 }

	22 </style>

	23

	24 <template id="target-template">

	25 <span class="container">

	26 <div class="target">x</span>

	27 </div>

	28 </template>

	29 <script src="resources/interpolation-test.js"></script>

	30 <script>

	31 assertInterpolation({

	32 property: 'font-size-adjust',

	33 from: '0',

	34 to: '1.2'

	35 }, [

	36 {at: -2, is: 'none'},

	37 {at: -0.3, is: 'none'},

	38 {at: 0, is: 'none'},

	39 {at: 0.3, is: 'none'},

	40 {at: 0.6, is: '1.2'},

	41 {at: 1, is: '1.2'},

	42 {at: 1.5, is: '1.2'},

	43 ]);

	44

	45 assertInterpolation({

	46 property: 'font-size-adjust',

	47 from: 'none',

	48 to: '1.2'

	49 }, [

	50 {at: -2, is: 'none'},

	51 {at: -0.3, is: 'none'},

	52 {at: 0, is: 'none'},

	53 {at: 0.3, is: 'none'},

	54 {at: 0.6, is: '1.2'},

	55 {at: 1, is: '1.2'},

	56 {at: 1.5, is: '1.2'},

	57 ]);

	58

	59 assertInterpolation({

	60 property: 'font-size-adjust',

	61 from: '0.2',

	62 to: '1.2'

	63 }, [

	64 {at: -2, is: 'none'}, // CSS font-size-adjust can't be negative.

	65 {at: -0.3, is: 'none'},
	dstockwell 2015/03/18 09:29:41 This illustrates one of the issues of treating 0 a This illustrates one of the issues of treating 0 as 'none'. An animation like this would have the text suddenly appear/disappear as the value reaches 0. We could work around this by clamping with a value slightly greater than 0, but I'm OK landing it this way for now. changseok 2015/03/18 09:58:37 Noted. Let's handle it in crbug.com/468236 as well Show quoted text On 2015/03/18 09:29:41, dstockwell wrote: > This illustrates one of the issues of treating 0 as 'none'. An animation like > this would have the text suddenly appear/disappear as the value reaches 0. We > could work around this by clamping with a value slightly greater than 0, but I'm > OK landing it this way for now. Noted. Let's handle it in crbug.com/468236 as well. Thanks!
	66 {at: 0, is: '0.2'},

	67 {at: 0.3, is: '0.5'},

	68 {at: 0.6, is: '0.8'},

	69 {at: 1, is: '1.2'},

	70 {at: 1.5, is: '1.7'},

	71 ]);

	72 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/animations/interpolation/font-size-adjust-interpolation-expected.txt » ('j') | no next file with comments »