Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: remoting/webapp/crd/js/menu_button.js

Issue 983023002: [Chromoting] Use compact notation for javascript @private types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/crd/js/log_to_server.js ('k') | remoting/webapp/crd/js/options_menu.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/crd/js/menu_button.js
diff --git a/remoting/webapp/crd/js/menu_button.js b/remoting/webapp/crd/js/menu_button.js
index 7d593bad46425ca905e337406c0f648d54828d13..a6bd3cf8bdf49c83976f62a00b21f49d6790eff3 100644
--- a/remoting/webapp/crd/js/menu_button.js
+++ b/remoting/webapp/crd/js/menu_button.js
@@ -22,29 +22,17 @@ var remoting = remoting || {};
* menu is hidden.
*/
remoting.MenuButton = function(container, opt_onShow, opt_onHide) {
- /**
- * @type {HTMLElement}
- * @private
- */
+ /** @private {HTMLElement} */
this.button_ = /** @type {HTMLElement} */
(container.querySelector('button,.menu-button-activator'));
- /**
- * @type {HTMLElement}
- * @private
- */
+ /** @private {HTMLElement} */
this.menu_ = /** @type {HTMLElement} */ (container.querySelector('ul'));
- /**
- * @type {undefined|function():void}
- * @private
- */
+ /** @private {undefined|function():void} */
this.onShow_ = opt_onShow;
- /**
- * @type {undefined|function():void}
- * @private
- */
+ /** @private {undefined|function():void} */
this.onHide_ = opt_onHide;
/**
@@ -54,8 +42,7 @@ remoting.MenuButton = function(container, opt_onShow, opt_onHide) {
* because elements can prevent event propagation; specifically, the client
* plugin element does this.
*
- * @type {HTMLElement}
- * @private
+ * @private {HTMLElement}
*/
this.clickTrap_ = /** @type {HTMLElement} */ (document.createElement('div'));
this.clickTrap_.classList.add('menu-button-click-trap');
« no previous file with comments | « remoting/webapp/crd/js/log_to_server.js ('k') | remoting/webapp/crd/js/options_menu.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698