Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 983023002: [Chromoting] Use compact notation for javascript @private types (Closed)

Created:
5 years, 9 months ago by garykac
Modified:
5 years, 9 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, dcheng, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Use compact notation for javascript @private types This is a mechanical change to replace single- and multi-line: @type {type} @private with single-line: @private {type} No functional changes in this cl - just updating the jscompiler annotations to make the code easier to read. BUG= Committed: https://crrev.com/2c49a01ae05c40ae6c4f74eca69fed9d237f9b51 Cr-Commit-Position: refs/heads/master@{#319518}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -592 lines) Patch
M remoting/webapp/app_remoting/js/app_remoting.js View 1 chunk +4 lines, -16 lines 0 comments Download
M remoting/webapp/app_remoting/js/application_context_menu.js View 2 chunks +2 lines, -8 lines 0 comments Download
M remoting/webapp/app_remoting/js/context_menu_dom.js View 1 chunk +9 lines, -34 lines 0 comments Download
M remoting/webapp/app_remoting/js/drag_and_drop.js View 1 chunk +9 lines, -31 lines 0 comments Download
M remoting/webapp/app_remoting/js/idle_detector.js View 1 chunk +2 lines, -6 lines 0 comments Download
M remoting/webapp/app_remoting/js/keyboard_layouts_menu.js View 1 chunk +3 lines, -12 lines 0 comments Download
M remoting/webapp/app_remoting/js/submenu_manager.js View 1 chunk +5 lines, -20 lines 0 comments Download
M remoting/webapp/app_remoting/js/window_activation_menu.js View 1 chunk +1 line, -4 lines 0 comments Download
M remoting/webapp/base/js/application.js View 2 chunks +3 lines, -12 lines 0 comments Download
M remoting/webapp/base/js/auth_dialog.js View 1 chunk +4 lines, -16 lines 0 comments Download
M remoting/webapp/base/js/ipc.js View 1 chunk +1 line, -4 lines 0 comments Download
M remoting/webapp/base/js/message_window.js View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/webapp/base/js/message_window_manager.js View 1 chunk +2 lines, -4 lines 0 comments Download
M remoting/webapp/base/js/window_shape.js View 1 chunk +3 lines, -8 lines 0 comments Download
M remoting/webapp/crd/js/activation_handler.js View 2 chunks +2 lines, -5 lines 0 comments Download
M remoting/webapp/crd/js/cast_extension_handler.js View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/webapp/crd/js/client_plugin_impl.js View 2 chunks +9 lines, -36 lines 0 comments Download
M remoting/webapp/crd/js/client_session.js View 2 chunks +3 lines, -4 lines 0 comments Download
M remoting/webapp/crd/js/clipboard.js View 1 chunk +3 lines, -12 lines 0 comments Download
M remoting/webapp/crd/js/connection_stats.js View 1 chunk +2 lines, -7 lines 0 comments Download
M remoting/webapp/crd/js/credentials_provider.js View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/webapp/crd/js/desktop_connected_view.js View 4 chunks +10 lines, -7 lines 0 comments Download
M remoting/webapp/crd/js/desktop_remoting.js View 2 chunks +2 lines, -4 lines 0 comments Download
M remoting/webapp/crd/js/dns_blackhole_checker.js View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/webapp/crd/js/fallback_signal_strategy.js View 2 chunks +12 lines, -46 lines 0 comments Download
M remoting/webapp/crd/js/fullscreen_v1.js View 1 chunk +2 lines, -8 lines 0 comments Download
M remoting/webapp/crd/js/fullscreen_v2.js View 1 chunk +2 lines, -8 lines 0 comments Download
M remoting/webapp/crd/js/host_daemon_facade.js View 1 chunk +8 lines, -15 lines 0 comments Download
M remoting/webapp/crd/js/host_install_dialog.js View 1 chunk +5 lines, -5 lines 0 comments Download
M remoting/webapp/crd/js/host_installer.js View 1 chunk +2 lines, -8 lines 0 comments Download
M remoting/webapp/crd/js/host_list.js View 1 chunk +10 lines, -38 lines 0 comments Download
M remoting/webapp/crd/js/identity.js View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/webapp/crd/js/it2me_host_facade.js View 2 chunks +4 lines, -14 lines 0 comments Download
M remoting/webapp/crd/js/log_to_server.js View 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/crd/js/menu_button.js View 2 chunks +5 lines, -18 lines 0 comments Download
M remoting/webapp/crd/js/options_menu.js View 1 chunk +1 line, -4 lines 0 comments Download
M remoting/webapp/crd/js/session_connector_impl.js View 2 chunks +17 lines, -67 lines 0 comments Download
M remoting/webapp/crd/js/stats_accumulator.js View 1 chunk +2 lines, -4 lines 0 comments Download
M remoting/webapp/crd/js/third_party_token_fetcher.js View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/webapp/crd/js/toolbar.js View 1 chunk +7 lines, -28 lines 0 comments Download
M remoting/webapp/crd/js/wcs.js View 1 chunk +4 lines, -8 lines 0 comments Download
M remoting/webapp/crd/js/wcs_adapter.js View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/webapp/crd/js/wcs_loader.js View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/webapp/crd/js/wcs_sandbox_container.js View 1 chunk +4 lines, -8 lines 0 comments Download
M remoting/webapp/crd/js/wcs_sandbox_content.js View 1 chunk +3 lines, -12 lines 0 comments Download
M remoting/webapp/crd/js/window_frame.js View 2 chunks +5 lines, -20 lines 0 comments Download
M remoting/webapp/crd/js/xhr_proxy.js View 1 chunk +2 lines, -7 lines 0 comments Download
M remoting/webapp/crd/js/xmpp_connection.js View 2 chunks +5 lines, -5 lines 0 comments Download
M remoting/webapp/crd/js/xmpp_login_handler.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
garykac
5 years, 9 months ago (2015-03-06 02:37:13 UTC) #2
kelvinp
lgtm
5 years, 9 months ago (2015-03-06 18:17:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/983023002/1
5 years, 9 months ago (2015-03-06 18:31:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-06 22:49:17 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 22:50:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c49a01ae05c40ae6c4f74eca69fed9d237f9b51
Cr-Commit-Position: refs/heads/master@{#319518}

Powered by Google App Engine
This is Rietveld 408576698