Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(945)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 982993002: Tentative fix for the crash when calling StartupAppLauncher::ContinueWithNetworkReady by clear the … (Closed)

Created:
5 years, 9 months ago by jennyz
Modified:
5 years, 9 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tentative fix for the crash when calling StartupAppLauncher::ContinueWithNetworkReady by clear the network wait timer if the code flow skipped AppLaunchController::OnInstallingApp for clearing it. BUG=464060 Committed: https://crrev.com/fc923439ed32f7944f57e89595cca4dba30f6306 Cr-Commit-Position: refs/heads/master@{#319472}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Clear network wait timer before starting launch_splash_timer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/browser/chromeos/login/app_launch_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/app_launch_controller.cc View 1 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
jennyz
5 years, 9 months ago (2015-03-05 23:35:18 UTC) #1
jennyz
5 years, 9 months ago (2015-03-06 17:37:18 UTC) #3
xiyuan
https://codereview.chromium.org/982993002/diff/1/chrome/browser/chromeos/login/app_launch_controller.cc File chrome/browser/chromeos/login/app_launch_controller.cc (right): https://codereview.chromium.org/982993002/diff/1/chrome/browser/chromeos/login/app_launch_controller.cc#newcode419 chrome/browser/chromeos/login/app_launch_controller.cc:419: ClearNetworkWaitTimer(); Let's do this before line 403 (starting splash_wait_timer_). ...
5 years, 9 months ago (2015-03-06 17:43:53 UTC) #4
jennyz
https://codereview.chromium.org/982993002/diff/1/chrome/browser/chromeos/login/app_launch_controller.cc File chrome/browser/chromeos/login/app_launch_controller.cc (right): https://codereview.chromium.org/982993002/diff/1/chrome/browser/chromeos/login/app_launch_controller.cc#newcode419 chrome/browser/chromeos/login/app_launch_controller.cc:419: ClearNetworkWaitTimer(); On 2015/03/06 17:43:52, xiyuan wrote: > Let's do ...
5 years, 9 months ago (2015-03-06 18:04:02 UTC) #5
xiyuan
lgtm
5 years, 9 months ago (2015-03-06 18:04:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/982993002/20001
5 years, 9 months ago (2015-03-06 18:25:48 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-06 19:13:09 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 19:14:02 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fc923439ed32f7944f57e89595cca4dba30f6306
Cr-Commit-Position: refs/heads/master@{#319472}

Powered by Google App Engine
This is Rietveld 408576698