Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: shell/application_manager/application_manager.h

Issue 982903002: Shell: Strip query string from URL when looking to apply native options. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | shell/application_manager/application_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/application_manager/application_manager.h
diff --git a/shell/application_manager/application_manager.h b/shell/application_manager/application_manager.h
index 38784d734f9d5fe881075a0e632b6866e1596a8f..fee8cdf09624d9d23851c9928a880d94278b03e3 100644
--- a/shell/application_manager/application_manager.h
+++ b/shell/application_manager/application_manager.h
@@ -110,9 +110,10 @@ class ApplicationManager {
// TODO(vtl): Maybe we should store/compare resolved URLs, like
// SetNativeOptionsForURL() below?
void SetArgsForURL(const std::vector<std::string>& args, const GURL& url);
- // These options will be used in running any native application at |url|.
- // (|url| will be mapped and resolved, and any application whose resolved URL
- // matches it will have |options| applied.)
+ // These options will be used in running any native application at |url|
+ // (which shouldn't contain a query string). (|url| will be mapped and
+ // resolved, and any application whose base resolved URL matches it will have
+ // |options| applied.)
// TODO(vtl): This may not do what's desired if the resolved URL results in an
// HTTP redirect. Really, we want options to be identified with a particular
// implementation, maybe via a signed manifest or something like that.
« no previous file with comments | « no previous file | shell/application_manager/application_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698