Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1139)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 982883004: Move GetUdevDevicePropertyValue from components/storage_monitor to device/udev_linux and rename to … (Closed)

Created:
5 years, 9 months ago by Adam Goode
Modified:
5 years, 9 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move GetUdevDevicePropertyValue from components/storage_monitor to device/udev_linux and rename to UdevDeviceGetPropertyValue I am going to use this as part of Web MIDI and don't want to depend on storage_monitor. Committed: https://crrev.com/7a59246fbaad653c031c346bded0421f5e6383ea Cr-Commit-Position: refs/heads/master@{#319415}

Patch Set 1 #

Patch Set 2 : Fix missing <string> include #

Patch Set 3 : Revert incorrect change in chromeos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -23 lines) Patch
M components/storage_monitor/storage_monitor_linux.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M components/storage_monitor/udev_util_linux.h View 1 chunk +0 lines, -5 lines 0 comments Download
M components/storage_monitor/udev_util_linux.cc View 2 chunks +1 line, -7 lines 0 comments Download
M device/udev_linux/udev.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M device/udev_linux/udev.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Adam Goode
5 years, 9 months ago (2015-03-06 03:18:06 UTC) #2
Lei Zhang
lgtm
5 years, 9 months ago (2015-03-06 03:25:54 UTC) #3
Ken Rockot(use gerrit already)
lgtm
5 years, 9 months ago (2015-03-06 05:25:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/982883004/40001
5 years, 9 months ago (2015-03-06 05:32:53 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-06 06:04:37 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 06:05:58 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/7a59246fbaad653c031c346bded0421f5e6383ea
Cr-Commit-Position: refs/heads/master@{#319415}

Powered by Google App Engine
This is Rietveld 408576698