Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: components/sync_driver/generic_change_processor_unittest.cc

Issue 982883002: [Sync] Add size and crc32c to AttachmentId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix argument evaluation order bug. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync_driver/generic_change_processor_unittest.cc
diff --git a/components/sync_driver/generic_change_processor_unittest.cc b/components/sync_driver/generic_change_processor_unittest.cc
index cb0a4fc93c8662fae2dfd6256bab45be4509c832..e262bfea0c7d3b50aa4f0946bd338cf04ed4bdc7 100644
--- a/components/sync_driver/generic_change_processor_unittest.cc
+++ b/components/sync_driver/generic_change_processor_unittest.cc
@@ -374,8 +374,8 @@ TEST_F(SyncGenericChangeProcessorTest,
pref_specifics->set_name("test");
syncer::AttachmentIdList attachment_ids;
- attachment_ids.push_back(syncer::AttachmentId::Create());
- attachment_ids.push_back(syncer::AttachmentId::Create());
+ attachment_ids.push_back(syncer::AttachmentId::Create(0, 0));
+ attachment_ids.push_back(syncer::AttachmentId::Create(0, 0));
// Add a SyncData with two attachments.
syncer::SyncChangeList change_list;
@@ -398,7 +398,7 @@ TEST_F(SyncGenericChangeProcessorTest,
// Update the SyncData, replacing its two attachments with one new attachment.
syncer::AttachmentIdList new_attachment_ids;
- new_attachment_ids.push_back(syncer::AttachmentId::Create());
+ new_attachment_ids.push_back(syncer::AttachmentId::Create(0, 0));
mock_attachment_service()->attachment_id_sets()->clear();
change_list.clear();
change_list.push_back(
@@ -428,7 +428,7 @@ TEST_F(SyncGenericChangeProcessorTest, AttachmentUploaded) {
pref_specifics->set_name("test");
syncer::AttachmentIdList attachment_ids;
- attachment_ids.push_back(syncer::AttachmentId::Create());
+ attachment_ids.push_back(syncer::AttachmentId::Create(0, 0));
// Add a SyncData with two attachments.
syncer::SyncChangeList change_list;
@@ -456,8 +456,8 @@ TEST_F(SyncGenericChangeProcessorTest, AttachmentUploaded) {
// scheduled for upload.
TEST_F(SyncGenericChangeProcessorTest, UploadAllAttachmentsNotOnServer) {
// Create two attachment ids. id2 will be marked as "on server".
- syncer::AttachmentId id1 = syncer::AttachmentId::Create();
- syncer::AttachmentId id2 = syncer::AttachmentId::Create();
+ syncer::AttachmentId id1 = syncer::AttachmentId::Create(0, 0);
+ syncer::AttachmentId id2 = syncer::AttachmentId::Create(0, 0);
{
// Write an entry containing these two attachment ids.
syncer::WriteTransaction trans(FROM_HERE, user_share());
« no previous file with comments | « no previous file | sync/api/attachments/attachment.h » ('j') | sync/api/attachments/attachment_metadata_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698