Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: sync/engine/directory_update_handler_unittest.cc

Issue 982883002: [Sync] Add size and crc32c to AttachmentId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge with master. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/engine/directory_update_handler_unittest.cc
diff --git a/sync/engine/directory_update_handler_unittest.cc b/sync/engine/directory_update_handler_unittest.cc
index 46e286015f5bd1af7b8f244b71d9c701a6ace4f5..2311d0fce83f41c8086b22d13f483d5714113db3 100644
--- a/sync/engine/directory_update_handler_unittest.cc
+++ b/sync/engine/directory_update_handler_unittest.cc
@@ -401,7 +401,7 @@ TEST_F(DirectoryUpdateHandlerProcessUpdateTest,
scoped_ptr<sync_pb::SyncEntity> e1 = CreateUpdate(
SyncableIdToProto(Id::CreateFromServerId("e1")), "", ARTICLES);
sync_pb::AttachmentIdProto* attachment_id = e1->add_attachment_id();
- *attachment_id = CreateAttachmentIdProto();
+ *attachment_id = CreateAttachmentIdProto(0, 0);
SyncEntityList updates;
updates.push_back(e1.get());
@@ -1080,8 +1080,10 @@ TEST_F(DirectoryUpdateHandlerApplyUpdateTest,
*specifics.mutable_article() = sync_pb::ArticleSpecifics();
int64 handle = entry_factory()->CreateSyncedItem("art1", ARTICLES, is_folder);
- sync_pb::AttachmentIdProto local_attachment_id = CreateAttachmentIdProto();
- sync_pb::AttachmentIdProto server_attachment_id = CreateAttachmentIdProto();
+ sync_pb::AttachmentIdProto local_attachment_id =
+ CreateAttachmentIdProto(0, 0);
+ sync_pb::AttachmentIdProto server_attachment_id =
+ CreateAttachmentIdProto(0, 0);
// Add an attachment to the local attachment metadata.
sync_pb::AttachmentMetadata local_metadata;
@@ -1122,8 +1124,8 @@ TEST_F(DirectoryUpdateHandlerApplyUpdateTest,
*specifics.mutable_article() = sync_pb::ArticleSpecifics();
int64 handle = entry_factory()->CreateSyncedItem("art1", ARTICLES, is_folder);
- sync_pb::AttachmentIdProto id1 = CreateAttachmentIdProto();
- sync_pb::AttachmentIdProto id2 = CreateAttachmentIdProto();
+ sync_pb::AttachmentIdProto id1 = CreateAttachmentIdProto(0, 0);
+ sync_pb::AttachmentIdProto id2 = CreateAttachmentIdProto(0, 0);
// Add id1, then id2 to the local attachment metadata.
sync_pb::AttachmentMetadata local_metadata;
« no previous file with comments | « sync/engine/directory_commit_contribution_unittest.cc ('k') | sync/internal_api/attachments/attachment_downloader_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698