sync/api/attachments/attachment_metadata.h - Issue 982883002: [Sync] Add size and crc32c to AttachmentId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/api/attachments/attachment_metadata.h

Issue 982883002: [Sync] Add size and crc32c to AttachmentId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge with master. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/api/attachments/attachment_metadata.h

diff --git a/sync/api/attachments/attachment_metadata.h b/sync/api/attachments/attachment_metadata.h

index 10761f838212df31222c658e09be1e8b2e7b66c6..6eef6c682d4dbbfa09523e0cd81ed6e56b5449fb 100644

--- a/sync/api/attachments/attachment_metadata.h

+++ b/sync/api/attachments/attachment_metadata.h

@@ -30,6 +30,9 @@ class SYNC_EXPORT AttachmentMetadata {

size_t GetSize() const;

private:

+ // TODO(maniscalco): Reconcile AttachmentMetadata and

+ // AttachmentId. AttachmentId knows the size of the attachment so

+ // AttachmentMetadata may not be necessary (crbug/465375).

AttachmentId id_;

size_t size_;

};