Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Side by Side Diff: sync/internal_api/public/base/attachment_id_proto_unittest.cc

Issue 982883002: [Sync] Add size and crc32c to AttachmentId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix argument evaluation order bug. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sync/internal_api/public/base/attachment_id_proto.h" 5 #include "sync/internal_api/public/base/attachment_id_proto.h"
6 6
7 #include "base/strings/string_util.h" 7 #include "base/strings/string_util.h"
8 #include "testing/gmock/include/gmock/gmock-matchers.h" 8 #include "testing/gmock/include/gmock/gmock-matchers.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 namespace syncer { 11 namespace syncer {
12 12
13 typedef testing::Test AttachmentIdProtoTest; 13 typedef testing::Test AttachmentIdProtoTest;
14 14
15 // Verify that that we generate a proto with a properly formatted unique_id 15 // Verify that that we generate a proto with a properly formatted unique_id
16 // field. 16 // field.
17 TEST(AttachmentIdProtoTest, UniqueIdFormat) { 17 TEST(AttachmentIdProtoTest, UniqueIdFormat) {
18 sync_pb::AttachmentIdProto id_proto = CreateAttachmentIdProto(); 18 sync_pb::AttachmentIdProto id_proto = CreateAttachmentIdProto(0, 0);
19 ASSERT_TRUE(id_proto.has_unique_id()); 19 ASSERT_TRUE(id_proto.has_unique_id());
20 // gtest's regular expression support is pretty poor so we cannot test as 20 // gtest's regular expression support is pretty poor so we cannot test as
21 // closely as we would like. 21 // closely as we would like.
22 EXPECT_THAT(id_proto.unique_id(), 22 EXPECT_THAT(id_proto.unique_id(),
23 testing::MatchesRegex( 23 testing::MatchesRegex(
24 "\\w\\w\\w\\w\\w\\w\\w\\w-\\w\\w\\w\\w-\\w\\w\\w\\w-" 24 "\\w\\w\\w\\w\\w\\w\\w\\w-\\w\\w\\w\\w-\\w\\w\\w\\w-"
25 "\\w\\w\\w\\w-\\w\\w\\w\\w\\w\\w\\w\\w\\w\\w\\w\\w")); 25 "\\w\\w\\w\\w-\\w\\w\\w\\w\\w\\w\\w\\w\\w\\w\\w\\w"));
26 EXPECT_EQ(base::StringToLowerASCII(id_proto.unique_id()), 26 EXPECT_EQ(base::StringToLowerASCII(id_proto.unique_id()),
27 id_proto.unique_id()); 27 id_proto.unique_id());
28 } 28 }
29 29
30 TEST(AttachmentIdProtoTest, CreateAttachmentMetadata_Empty) { 30 TEST(AttachmentIdProtoTest, CreateAttachmentMetadata_Empty) {
31 google::protobuf::RepeatedPtrField<sync_pb::AttachmentIdProto> ids; 31 google::protobuf::RepeatedPtrField<sync_pb::AttachmentIdProto> ids;
32 sync_pb::AttachmentMetadata metadata = CreateAttachmentMetadata(ids); 32 sync_pb::AttachmentMetadata metadata = CreateAttachmentMetadata(ids);
33 EXPECT_EQ(0, metadata.record_size()); 33 EXPECT_EQ(0, metadata.record_size());
34 } 34 }
35 35
36 TEST(AttachmentIdProtoTest, CreateAttachmentMetadata_NonEmpty) { 36 TEST(AttachmentIdProtoTest, CreateAttachmentMetadata_NonEmpty) {
37 google::protobuf::RepeatedPtrField<sync_pb::AttachmentIdProto> ids; 37 google::protobuf::RepeatedPtrField<sync_pb::AttachmentIdProto> ids;
38 *ids.Add() = CreateAttachmentIdProto(); 38 *ids.Add() = CreateAttachmentIdProto(0, 0);
39 *ids.Add() = CreateAttachmentIdProto(); 39 *ids.Add() = CreateAttachmentIdProto(0, 0);
40 *ids.Add() = CreateAttachmentIdProto(); 40 *ids.Add() = CreateAttachmentIdProto(0, 0);
41 sync_pb::AttachmentMetadata metadata = CreateAttachmentMetadata(ids); 41 sync_pb::AttachmentMetadata metadata = CreateAttachmentMetadata(ids);
42 ASSERT_EQ(3, metadata.record_size()); 42 ASSERT_EQ(3, metadata.record_size());
43 for (int i = 0; i < metadata.record_size(); ++i) { 43 for (int i = 0; i < metadata.record_size(); ++i) {
44 EXPECT_EQ(ids.Get(i).SerializeAsString(), 44 EXPECT_EQ(ids.Get(i).SerializeAsString(),
45 metadata.record(i).id().SerializeAsString()); 45 metadata.record(i).id().SerializeAsString());
46 EXPECT_TRUE(metadata.record(i).is_on_server()); 46 EXPECT_TRUE(metadata.record(i).is_on_server());
47 } 47 }
48 } 48 }
49 49
50 } // namespace syncer 50 } // namespace syncer
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698