Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: sync/api/attachments/attachment_metadata.h

Issue 982883002: [Sync] Add size and crc32c to AttachmentId. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge with master. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SYNC_API_ATTACHMENTS_ATTACHMENT_METADATA_H_ 5 #ifndef SYNC_API_ATTACHMENTS_ATTACHMENT_METADATA_H_
6 #define SYNC_API_ATTACHMENTS_ATTACHMENT_METADATA_H_ 6 #define SYNC_API_ATTACHMENTS_ATTACHMENT_METADATA_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 12 matching lines...) Expand all
23 23
24 // Default copy and assignment are welcome. 24 // Default copy and assignment are welcome.
25 25
26 // Returns this attachment's id. 26 // Returns this attachment's id.
27 const AttachmentId& GetId() const; 27 const AttachmentId& GetId() const;
28 28
29 // Returns this attachment's size in bytes. 29 // Returns this attachment's size in bytes.
30 size_t GetSize() const; 30 size_t GetSize() const;
31 31
32 private: 32 private:
33 // TODO(maniscalco): Reconcile AttachmentMetadata and
34 // AttachmentId. AttachmentId knows the size of the attachment so
35 // AttachmentMetadata may not be necessary (crbug/465375).
33 AttachmentId id_; 36 AttachmentId id_;
34 size_t size_; 37 size_t size_;
35 }; 38 };
36 39
37 typedef std::vector<syncer::AttachmentMetadata> AttachmentMetadataList; 40 typedef std::vector<syncer::AttachmentMetadata> AttachmentMetadataList;
38 41
39 } // namespace syncer 42 } // namespace syncer
40 43
41 #endif // SYNC_API_ATTACHMENTS_ATTACHMENT_METADATA_H_ 44 #endif // SYNC_API_ATTACHMENTS_ATTACHMENT_METADATA_H_
OLDNEW
« no previous file with comments | « sync/api/attachments/attachment_id_unittest.cc ('k') | sync/api/attachments/attachment_metadata_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698