runtime/vm/regexp_test.cc - Issue 982873004: Thread/Isolate refactoring: new(Isolate) -> new(Zone)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/regexp_test.cc

Issue 982873004: Thread/Isolate refactoring: new(Isolate) -> new(Zone) (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/regexp_test.cc

===================================================================

--- runtime/vm/regexp_test.cc (revision 44266)

+++ runtime/vm/regexp_test.cc (working copy)

@@ -14,14 +14,14 @@

DECLARE_FLAG(bool, use_jscre);

static RawArray* Match(const String& pat, const String& str) {

- Isolate* isolate = Isolate::Current();

+ Zone* zone = Thread::Current()->zone();

const JSRegExp& regexp = JSRegExp::Handle(

- RegExpEngine::CreateJSRegExp(isolate, pat, false, false));

+ RegExpEngine::CreateJSRegExp(zone, pat, false, false));

const intptr_t cid = str.GetClassId();

const Function& fn = Function::Handle(regexp.function(cid));

EXPECT(!fn.IsNull());

const Smi& idx = Smi::Handle(Smi::New(0));

- return IRRegExpMacroAssembler::Execute(fn, str, idx, Isolate::Current());

+ return IRRegExpMacroAssembler::Execute(fn, str, idx, zone);

}

TEST_CASE(RegExp_OneByteString) {

« no previous file with comments | « runtime/vm/regexp_parser.cc ('k') | runtime/vm/runtime_entry.h » ('j') | no next file with comments »