Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Unified Diff: runtime/vm/native_entry.h

Issue 982873004: Thread/Isolate refactoring: new(Isolate) -> new(Zone) (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/native_entry.h
===================================================================
--- runtime/vm/native_entry.h (revision 44266)
+++ runtime/vm/native_entry.h (working copy)
@@ -39,6 +39,8 @@
#define DEFINE_NATIVE_ENTRY(name, argument_count) \
static RawObject* DN_Helper##name(Isolate* isolate, \
+ Thread* thread, \
+ Zone* zone, \
NativeArguments* arguments); \
void NATIVE_ENTRY_FUNCTION(name)(Dart_NativeArguments args) { \
CHECK_STACK_ALIGNMENT; \
@@ -49,14 +51,22 @@
ASSERT(arguments->NativeArgCount() == argument_count); \
TRACE_NATIVE_CALL("%s", ""#name); \
{ \
- StackZone zone(arguments->isolate()); \
+ Isolate* isolate = arguments->isolate(); \
+ /* TODO(koda): Pivot from Isolate to Thread in NativeArguments. */ \
+ Thread* thread = Thread::CurrentFromCurrentIsolate(isolate); \
+ StackZone zone(isolate); \
SET_NATIVE_RETVAL(arguments, \
- DN_Helper##name(arguments->isolate(), arguments)); \
+ DN_Helper##name(isolate, \
+ thread, \
+ zone.GetZone(), \
+ arguments)); \
DEOPTIMIZE_ALOT; \
} \
VERIFY_ON_TRANSITION; \
} \
static RawObject* DN_Helper##name(Isolate* isolate, \
+ Thread* thread, \
+ Zone* zone, \
NativeArguments* arguments)
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698