Thread/Isolate refactoring: new(Isolate) -> new(Zone)

runtime/vm/flow_graph.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph.h"
 
 #include "vm/bit_vector.h"
 #include "vm/flow_graph_builder.h"
 #include "vm/il_printer.h"
 #include "vm/intermediate_language.h"
@@ skipping 118 matching lines @@
 void FlowGraph::InsertAfter(Instruction* prev,
                             Instruction* instr,
                             Environment* env,
                             UseKind use_kind) {
   if (use_kind == kValue) {
     ASSERT(instr->IsDefinition());
     AllocateSSAIndexes(instr->AsDefinition());
   }
   instr->InsertAfter(prev);
   ASSERT(instr->env() == NULL);
-  if (env != NULL) env->DeepCopyTo(isolate(), instr);
+  if (env != NULL) env->DeepCopyTo(zone(), instr);

[Ivan Posva, 2015/03/13 21:56:50]

Please add
{
  ...
}

[koda, 2015/03/14 00:46:37]

Done.

 }
 
 
 Instruction* FlowGraph::AppendTo(Instruction* prev,
                                  Instruction* instr,
                                  Environment* env,
                                  UseKind use_kind) {
   if (use_kind == kValue) {
     ASSERT(instr->IsDefinition());
     AllocateSSAIndexes(instr->AsDefinition());
   }
   ASSERT(instr->env() == NULL);
-  if (env != NULL) env->DeepCopyTo(isolate(), instr);
+  if (env != NULL) env->DeepCopyTo(zone(), instr);

[Ivan Posva, 2015/03/13 21:56:50]

ditto

[koda, 2015/03/14 00:46:37]

Done.

   return prev->AppendInstruction(instr);
 }
 
 
 // A wrapper around block entries including an index of the next successor to
 // be read.
 class BlockTraversalState {
  public:
   explicit BlockTraversalState(BlockEntryInstr* block)
     : block_(block),
@@ skipping 714 matching lines @@
     // on entry to the catch.
     entry->set_fixed_slot_count(num_stack_locals() + num_copied_params());
   }
   RenameRecursive(entry, &env, live_phis, variable_liveness);
 }
 
 
 void FlowGraph::AttachEnvironment(Instruction* instr,
                                   GrowableArray<Definition*>* env) {
   Environment* deopt_env =
-      Environment::From(isolate(),
+      Environment::From(zone(),
                         *env,
                         num_non_copied_params_,
                         parsed_function_);
   if (instr->IsClosureCall()) {
-    deopt_env = deopt_env->DeepCopy(isolate(),
+    deopt_env = deopt_env->DeepCopy(zone(),
                                     deopt_env->Length() - instr->InputCount());
   }
   instr->SetEnvironment(deopt_env);
   for (Environment::DeepIterator it(deopt_env); !it.Done(); it.Advance()) {
     Value* use = it.CurrentValue();
     use->definition()->AddEnvUse(use);
   }
   if (instr->CanDeoptimize()) {
     instr->env()->set_deopt_id(instr->deopt_id());
   }
@@ skipping 481 matching lines @@
 }
 
 
 bool BlockEffects::IsSideEffectFreePath(BlockEntryInstr* from,
                                         BlockEntryInstr* to) const {
   return available_at_[to->postorder_number()]->Contains(
       from->postorder_number());
 }
 
 }  // namespace dart