Issue 98283004: Fixing problem with M33->M32->M33 transitions & pinned app preferences

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 98283004: Fixing problem with M33->M32->M33 transitions & pinned app preferences (Closed)

Created:
7 years ago by Mr4D (OOO till 08-26)

Modified:
7 years ago

Reviewers:
xiyuan, Daniel Erat

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixing problem with M33->M32->M33 transitions & pinned app preferences I kept this CL as simple as possible to allow a backport to M33 and maybe even M32 if desired. BUG=329597 TEST=unittest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241781

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -0 lines)			Patch
	M	chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc	View		1 chunk	+7 lines, -0 lines	1 comment	Download
	M	chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc	View		1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/98283004/20001

7 years ago (2013-12-19 00:15:31 UTC) #3

Daniel Erat

7 years ago (2013-12-19 16:59:45 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/98283004/diff/20001/chrome/browser/ui/ash/lau...
File chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc (right):

https://codereview.chromium.org/98283004/diff/20001/chrome/browser/ui/ash/lau...
chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc:1840: // instead
ask the ShelfModel::ValidateInsertionIndex or similir for an index.
nit: s/similir/similar/

Expand Messages | Collapse Messages