Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 982793002: Don't double-allocate mutable heap numbers in the json parser. This removes some stupidity when com… (Closed)

Created:
5 years, 9 months ago by Toon Verwaest
Modified:
5 years, 9 months ago
Reviewers:
Igor Sheludko, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't double-allocate mutable heap numbers in the json parser. This removes some stupidity when committing state. BUG= Committed: https://crrev.com/67d531c33c7bec956810189273ab51beae8a0727 Cr-Commit-Position: refs/heads/master@{#27034}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -53 lines) Patch
M src/json-parser.h View 4 chunks +7 lines, -27 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M src/objects-inl.h View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
PTAL
5 years, 9 months ago (2015-03-05 14:33:52 UTC) #2
Igor Sheludko
Nice. lgtm
5 years, 9 months ago (2015-03-06 07:53:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/982793002/1
5 years, 9 months ago (2015-03-06 08:04:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-06 08:37:18 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 08:37:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67d531c33c7bec956810189273ab51beae8a0727
Cr-Commit-Position: refs/heads/master@{#27034}

Powered by Google App Engine
This is Rietveld 408576698