Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 982683003: Revert of Adding Maps page to page_sets for telemetry. (Closed)

Created:
5 years, 9 months ago by xhwang
Modified:
5 years, 9 months ago
Reviewers:
picksi1, Sami, ssid, petrcermak
Base URL:
https://chromium.googlesource.com/chromium/src.git@mousedrag2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adding Maps page to page_sets for telemetry. (patchset #7 id:310001 of https://codereview.chromium.org/955653003/) Reason for revert: Failed tests in drag_unittest.py: http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.9%20Tests&number=3803 Original issue's description: > Adding Maps page to page_sets for telemetry. > > This CL adds google maps page to telemetry, and runs a synthetic drag > gesture on the page. This helps testing of maps page in telemetry to > track the performance on desktop chrome. > > BUG=457148 > > Committed: https://crrev.com/f502701b2bcc43c05d82e5780b2d6cf2d326bc23 > Cr-Commit-Position: refs/heads/master@{#319135} TBR=skyostil@chromium.org,picksi@chromium.org,petrcermak@chromium.org,ssid@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=457148 Committed: https://crrev.com/9589b67f3b415a742c7f65ebd106e202f5a01f42 Cr-Commit-Position: refs/heads/master@{#319171}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -358 lines) Patch
M tools/perf/page_sets/data/top_25.json View 2 chunks +2 lines, -2 lines 0 comments Download
D tools/perf/page_sets/data/top_25_004.wpr.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/data/top_25_smooth.json View 2 chunks +1 line, -4 lines 0 comments Download
M tools/perf/page_sets/top_25_smooth.py View 2 chunks +0 lines, -20 lines 0 comments Download
M tools/perf/page_sets/top_pages.py View 1 chunk +0 lines, -21 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/action_runner.py View 2 chunks +0 lines, -30 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/drag.js View 1 chunk +0 lines, -70 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/drag.py View 1 chunk +0 lines, -104 lines 0 comments Download
D tools/telemetry/telemetry/page/actions/drag_unittest.py View 1 chunk +0 lines, -54 lines 0 comments Download
D tools/telemetry/unittest_data/draggable.html View 1 chunk +0 lines, -52 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
xhwang
Created Revert of Adding Maps page to page_sets for telemetry.
5 years, 9 months ago (2015-03-05 00:19:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/982683003/1
5 years, 9 months ago (2015-03-05 00:21:09 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-05 00:22:12 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 00:22:50 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9589b67f3b415a742c7f65ebd106e202f5a01f42
Cr-Commit-Position: refs/heads/master@{#319171}

Powered by Google App Engine
This is Rietveld 408576698