Adds option to allow lint.py script to exit with nonzero exit status (fail builds).

Adds option to allow lint.py script to exit with nonzero exit status (fail builds).

We want to remove downstream lint script. We will need this script to be able to fail
builds if we want to replace the downstream script with this one.

BUG=266140
Committed: https://crrev.com/2b6f0c85fc4dcdb1746c4ac717b4b71c96e6e22a
Cr-Commit-Position: refs/heads/master@{#319481}

[mikecase (-- gone --), 2015-03-04 23:56:09]

mikecase@chromium.org changed reviewers:
+ aurimas@chromium.org

[aurimas (slooooooooow), 2015-03-05 00:48:19]

Why do we need an option for this? When do we want not to fail builds?

[mikecase (-- gone --), 2015-03-05 01:00:27]

On 2015/03/05 00:48:19, aurimas wrote:
> Why do we need an option for this? When do we want not to fail builds?

The upstream lint.py will currently never fail the build.
# Lint errors do not fail the build.
return 0

Currently, if you build you get quite a few lint errors. So if I make the change
to have the script always fail the build, it would cause lots of stuff to fail.
Once all the current lint errors are fixed it would be nice to make this script
fail builds so people don't make new lint errors.

Really this change is so I can delete the downstream lint script. That
downstream lint script is run by some of the bots (downstream clang builder for
example) and to replace it I need the upstream lint script to fail (nonzero exit
status) for the bots to show up red if there are lint errors.

[aurimas (slooooooooow), 2015-03-05 03:43:14]

lgtm

[mikecase (-- gone --), 2015-03-05 17:09:53]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2015-03-05 17:10:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/982683002/1

[commit-bot: I haz the power, 2015-03-05 17:31:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-05 17:31:59]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mikecase (-- gone --), 2015-03-05 17:52:03]

mikecase@chromium.org changed reviewers:
+ cjhopman@chromium.org

[mikecase (-- gone --), 2015-03-05 17:52:03]

+ cjhopman for review of build/android/gyp.

Also, cjhopman, would it be ok with you if I moved lint.py from
build/android/gyp/lint.py to build/android/lint/lint.py?

[cjhopman, 2015-03-06 01:29:33]

On 2015/03/05 17:52:03, mikecase wrote:
> + cjhopman for review of build/android/gyp.
> 
> Also, cjhopman, would it be ok with you if I moved lint.py from
> build/android/gyp/lint.py to build/android/lint/lint.py?

lgtm

I would prefer if it stayed in build/android/gyp. Why do you want to move it?

[mikecase (-- gone --), 2015-03-06 01:38:15]

The CQ bit was checked by mikecase@chromium.org

[mikecase (-- gone --), 2015-03-06 01:38:18]

The CQ bit was unchecked by mikecase@chromium.org

[mikecase (-- gone --), 2015-03-06 01:46:37]

On 2015/03/06 01:29:33, cjhopman wrote:
> On 2015/03/05 17:52:03, mikecase wrote:
> > + cjhopman for review of build/android/gyp.
> > 
> > Also, cjhopman, would it be ok with you if I moved lint.py from
> > build/android/gyp/lint.py to build/android/lint/lint.py?
> 
> lgtm
> 
> I would prefer if it stayed in build/android/gyp. Why do you want to move it?

Not a big deal, I'm fine with leaving it. Some of the bots that are using the
downstream lint script (like the clang builder) I'm changing to use this lint
script instead. Since they just call the script directly and not indirectly
through building, I thought it was a little awkward for the script to be in
gyp/. Also the lint/ folder already exists and the only thing it has is the
lint_suppression xml created by this script.

[mikecase (-- gone --), 2015-03-06 17:15:04]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2015-03-06 17:15:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/982683002/1

[commit-bot: I haz the power, 2015-03-06 19:49:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-06 19:50:26]

Patchset 1 (id:??) landed as
https://crrev.com/2b6f0c85fc4dcdb1746c4ac717b4b71c96e6e22a
Cr-Commit-Position: refs/heads/master@{#319481}