Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: services/dart/test/pingpong/main.dart

Issue 982673002: Dart: Removes need to call listen(). (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Don't pile up callbacks Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/dart/test/pingpong/main.dart
diff --git a/services/dart/test/pingpong/main.dart b/services/dart/test/pingpong/main.dart
index 9f7485d74bca8b3ab7f03b2414ffdba5c9ef212d..92e02f52cc3fd0f9ea9cf68364980adcb30e6079 100644
--- a/services/dart/test/pingpong/main.dart
+++ b/services/dart/test/pingpong/main.dart
@@ -32,17 +32,14 @@ class PingPongServiceImpl implements PingPongService {
Application _application;
PingPongClientProxy _pingPongClient;
- PingPongServiceImpl(Application application, MojoMessagePipeEndpoint endpoint)
- : _application = application {
- _stub = new PingPongServiceStub.fromEndpoint(endpoint, impl: this);
+ PingPongServiceImpl(this._application, MojoMessagePipeEndpoint endpoint) {
+ _stub = new PingPongServiceStub.fromEndpoint(endpoint, this);
}
PingPongServiceImpl.fromStub(this._stub) {
_stub.impl = this;
}
- listen() => _stub.listen();
-
void setClient(ProxyBase proxyBase) {
assert(_pingPongClient == null);
_pingPongClient = proxyBase;
@@ -64,7 +61,6 @@ class PingPongServiceImpl implements PingPongService {
var pingPongClient = new PingPongClientImpl.unbound(count, completer);
pingPongService.ptr.setClient(pingPongClient.stub);
- pingPongClient.stub.listen();
for (var i = 0; i < count; i++) {
pingPongService.ptr.ping(i);
@@ -76,13 +72,13 @@ class PingPongServiceImpl implements PingPongService {
return responseFactory(true);
}
- Future pingTargetService(ProxyBase proxyBase, int count,
- Function responseFactory) async {
+ Future pingTargetService(ProxyBase proxyBase,
+ int count,
+ Function responseFactory) async {
var pingPongService = proxyBase;
var completer = new Completer();
var client = new PingPongClientImpl.unbound(count, completer);
pingPongService.ptr.setClient(client.stub);
- client.stub.listen();
for (var i = 0; i < count; i++) {
pingPongService.ptr.ping(i);
@@ -95,7 +91,7 @@ class PingPongServiceImpl implements PingPongService {
}
getPingPongService(PingPongServiceStub serviceStub) {
- new PingPongServiceImpl.fromStub(serviceStub)..listen();
+ new PingPongServiceImpl.fromStub(serviceStub);
}
void quit() {
@@ -117,7 +113,6 @@ class PingPongApplication extends Application {
connection.provideService(
PingPongServiceName,
(endpoint) => new PingPongServiceImpl(this, endpoint));
- connection.listen();
}
}

Powered by Google App Engine
This is Rietveld 408576698