handler: Add report upload

handler/mac/crash_report_exception_handler.h

Index: handler/mac/crash_report_exception_handler.h
diff --git a/handler/mac/crash_report_exception_handler.h b/handler/mac/crash_report_exception_handler.h
index 8f81102e3a4812438badec36dfce0a5b2e02697d..f44a989e7579114a2a4c707859a1deaa8c6cda60 100644
--- a/handler/mac/crash_report_exception_handler.h
+++ b/handler/mac/crash_report_exception_handler.h
@@ -17,6 +17,9 @@
 
 #include <mach/mach.h>
 
+#include <map>
+#include <string>
+
 #include "base/basictypes.h"
 #include "client/crash_report_database.h"
 #include "handler/mac/crash_report_upload_thread.h"
@@ -33,8 +36,12 @@ class CrashReportExceptionHandler : public UniversalMachExcServer::Interface {
   //! \param[in] database The database to store crash reports in. Weak.
   //! \param[in] upload_thread The upload thread to notify when a new crash
   //!     report is written into \a database.
-  CrashReportExceptionHandler(CrashReportDatabase* database,
-                              CrashReportUploadThread* upload_thread);
+  //! \param[in] process_annotations A map of annotations to insert into each

[Robert Sesek, 2015/03/05 00:14:42]

Chrome's crash keys will not be set here, correct? Chrome's will be from the
Framework's module of annotations. If so, what are some example process
annotations?

+  //!     crash report that is written as process-level annotations.
+  CrashReportExceptionHandler(
+      CrashReportDatabase* database,
+      CrashReportUploadThread* upload_thread,
+      const std::map<std::string, std::string>& process_annotations);

[Robert Sesek, 2015/03/05 00:14:42]

Since this parameter is being stored by reference, it may be better to use a
pointer here to convey to the caller the lifetime requirements (i.e. this is not
copied).

[Mark Mentovai, 2015/03/05 19:41:31]

Robert Sesek wrote:
I used a reference because that’s what the callee,
ProcessSnapshotMac::SetAnnotationsSimpleMap(), wanted. But I can store a pointer
instead, I’ve just got to do the *dereference where it’s used now.

 
   ~CrashReportExceptionHandler();
 
@@ -61,6 +68,7 @@ class CrashReportExceptionHandler : public UniversalMachExcServer::Interface {
  private:
   CrashReportDatabase* database_;  // weak
   CrashReportUploadThread* upload_thread_;  // weak
+  const std::map<std::string, std::string>& process_annotations_;
 
   DISALLOW_COPY_AND_ASSIGN(CrashReportExceptionHandler);
 };