Chromium Code Reviews
Help | Chromium Project | Sign in
(15)

Issue 9826024: Added presubmit warning for ScopedAllowIO uses (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 5 months ago by Joao da Silva
Modified:
3 years, 5 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Added presubmit warning for ScopedAllowIO uses BUG=119550 TEST=Adding new uses of ScopedAllowIO triggers a presubmit warning Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128312

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M PRESUBMIT.py View 2 chunks +18 lines, -0 lines 0 comments Download
Project "None" does not have a commit queue.

Messages

Total messages: 4 (0 generated)
Joao da Silva
Please review, thanks!
3 years, 5 months ago (2012-03-22 19:59:15 UTC) #1
M-A Ruel
lgtm
3 years, 5 months ago (2012-03-22 20:00:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/9826024/1
3 years, 5 months ago (2012-03-22 20:09:17 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2012-03-22 21:44:42 UTC) #4
Change committed as 128312
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 020f378