Fix BluetoothAdapterProfileChromeOS lifecycle management

device/bluetooth/bluetooth_chromeos_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_vector.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/dbus/fake_bluetooth_adapter_client.h"
@@ skipping 306 matching lines @@
     ++callback_count_;
     discovery_sessions_.push_back(discovery_session.release());
     QuitMessageLoop();
   }
 
   void AudioSinkAcquiredCallback(scoped_refptr<BluetoothAudioSink>) {
     ++callback_count_;
     QuitMessageLoop();
   }
 
-  void ProfileRegisteredCallback(BluetoothAdapterProfileChromeOS*) {
+  void ProfileRegisteredCallback(BluetoothAdapterProfileChromeOS* profile) {
+    adapter_profile_ = profile;
     ++callback_count_;
     QuitMessageLoop();
   }
 
   void ErrorCallback() {
     ++error_callback_count_;
     QuitMessageLoop();
   }
 
   base::Closure GetErrorCallback() {
@@ skipping 81 matching lines @@
   base::MessageLoop message_loop_;
   FakeBluetoothAdapterClient* fake_bluetooth_adapter_client_;
   FakeBluetoothDeviceClient* fake_bluetooth_device_client_;
   scoped_refptr<BluetoothAdapter> adapter_;
 
   int callback_count_;
   int error_callback_count_;
   enum BluetoothDevice::ConnectErrorCode last_connect_error_;
   std::string last_client_error_;
   ScopedVector<BluetoothDiscoverySession> discovery_sessions_;
+  BluetoothAdapterProfileChromeOS* adapter_profile_;
 
  private:
   // Some tests use a message loop since background processing is simulated;
   // break out of those loops.
   void QuitMessageLoop() {
     if (base::MessageLoop::current() &&
         base::MessageLoop::current()->is_running())
       base::MessageLoop::current()->Quit();
   }
 };
@@ skipping 2742 matching lines @@
   // NotifyGattDiscoveryComplete
   // NotifyGattCharacteristicAdded
   // NotifyGattCharacteristicRemoved
   // NotifyGattDescriptorAdded
   // NotifyGattDescriptorRemoved
   // NotifyGattCharacteristicValueChanged
   // NotifyGattDescriptorValueChanged
 
   EXPECT_EQ(dbus::ObjectPath(""), adapter_chrome_os->object_path());
 
+  adapter_profile_ = NULL;
+
   FakeBluetoothProfileServiceProviderDelegate profile_delegate;
   adapter_chrome_os->UseProfile(
       BluetoothUUID(), dbus::ObjectPath(""),
       BluetoothProfileManagerClient::Options(), &profile_delegate,
       base::Bind(&BluetoothChromeOSTest::ProfileRegisteredCallback,
                  base::Unretained(this)),
       base::Bind(&BluetoothChromeOSTest::ErrorCompletionCallback,
                  base::Unretained(this)));
-  base::MessageLoop::current()->Run();
-  EXPECT_EQ(1, callback_count_--) << "UseProfile error";
-  EXPECT_EQ(0, error_callback_count_) << "UseProfile error";
 
-  adapter_chrome_os->ReleaseProfile(BluetoothUUID());
+  EXPECT_FALSE(adapter_profile_) << "UseProfile error";
+  EXPECT_EQ(0, callback_count_) << "UseProfile error";
+  EXPECT_EQ(1, error_callback_count_--) << "UseProfile error";
 
   // Protected and private methods:
 
   adapter_chrome_os->RemovePairingDelegateInternal(&pairing_delegate);
 
   // BluetoothAdapterClient::Observer methods omitted, dbus will be shutdown.
   // BluetoothDeviceClient::Observer methods omitted, dbus will be shutdown.
   // BluetoothInputClient::Observer methods omitted, dbus will be shutdown.
   // BluetoothAgentServiceProvider::Delegate omitted, dbus will be shutdown,
   //   with the exception of Released.
@@ skipping 37 matching lines @@
 
   adapter_chrome_os->RemoveDiscoverySession(GetCallback(), GetErrorCallback());
   EXPECT_EQ(0, callback_count_) << "RemoveDiscoverySession error";
   EXPECT_EQ(1, error_callback_count_--) << "RemoveDiscoverySession error";
 
   // OnStartDiscovery tested in Shutdown_OnStartDiscovery
   // OnStartDiscoveryError tested in Shutdown_OnStartDiscoveryError
   // OnStopDiscovery tested in Shutdown_OnStopDiscovery
   // OnStopDiscoveryError tested in Shutdown_OnStopDiscoveryError
 
+  adapter_profile_ = NULL;
+
   // OnRegisterProfile SetProfileDelegate, OnRegisterProfileError, require
   // UseProfile to be set first, do so again here just before calling them.
   adapter_chrome_os->UseProfile(
       BluetoothUUID(), dbus::ObjectPath(""),
       BluetoothProfileManagerClient::Options(), &profile_delegate,
       base::Bind(&BluetoothChromeOSTest::ProfileRegisteredCallback,
                  base::Unretained(this)),
       base::Bind(&BluetoothChromeOSTest::ErrorCompletionCallback,
                  base::Unretained(this)));
 
-  adapter_chrome_os->OnRegisterProfile(
-      BluetoothUUID(), dbus::ObjectPath(""), &profile_delegate,
-      base::Bind(&BluetoothChromeOSTest::ProfileRegisteredCallback,
-                 base::Unretained(this)),
-      base::Bind(&BluetoothChromeOSTest::ErrorCompletionCallback,
-                 base::Unretained(this)));
-  EXPECT_EQ(1, callback_count_--) << "OnRegisterProfile error";
-  EXPECT_EQ(1, error_callback_count_--) << "OnRegisterProfile error";
+  EXPECT_FALSE(adapter_profile_) << "UseProfile error";
+  EXPECT_EQ(0, callback_count_) << "UseProfile error";
+  EXPECT_EQ(1, error_callback_count_--) << "UseProfile error";
 
   adapter_chrome_os->SetProfileDelegate(
       BluetoothUUID(), dbus::ObjectPath(""), &profile_delegate,
       base::Bind(&BluetoothChromeOSTest::ProfileRegisteredCallback,
                  base::Unretained(this)),
       base::Bind(&BluetoothChromeOSTest::ErrorCompletionCallback,
                  base::Unretained(this)));
   EXPECT_EQ(0, callback_count_) << "SetProfileDelegate error";
   EXPECT_EQ(1, error_callback_count_--) << "SetProfileDelegate error";
 
-  adapter_chrome_os->OnRegisterProfileError(
-      BluetoothUUID(),
-      base::Bind(&BluetoothChromeOSTest::ErrorCompletionCallback,
-                 base::Unretained(this)),
-      "", "");
+  adapter_chrome_os->OnRegisterProfileError(BluetoothUUID(), "", "");
   EXPECT_EQ(0, callback_count_) << "OnRegisterProfileError error";
-  EXPECT_EQ(1, error_callback_count_--) << "OnRegisterProfileError error";
+  EXPECT_EQ(0, error_callback_count_) << "OnRegisterProfileError error";
 
   adapter_chrome_os->ProcessQueuedDiscoveryRequests();
 
   // From BluetoothAdapater:
 
   adapter_->StartDiscoverySession(
       base::Bind(&BluetoothChromeOSTest::DiscoverySessionCallback,
                  base::Unretained(this)),
       GetErrorCallback());
   EXPECT_EQ(0, callback_count_) << "StartDiscoverySession error";
@@ skipping 91 matching lines @@
   adapter_->Shutdown();
   adapter_chrome_os->OnStopDiscoveryError(GetErrorCallback(), "", "");
 
   // 1 error reported to RemoveDiscoverySession because of OnStopDiscoveryError,
   // and kNumberOfDiscoverySessions errors queued with AddDiscoverySession.
   EXPECT_EQ(0, callback_count_);
   EXPECT_EQ(1 + kNumberOfDiscoverySessions, error_callback_count_);
 }
 
 }  // namespace chromeos