Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Side by Side Diff: device/bluetooth/bluetooth_adapter_profile_chromeos.cc

Issue 982593002: Fix BluetoothAdapterProfileChromeOS lifecycle management (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address nits, remove test debug logging Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "device/bluetooth/bluetooth_adapter_profile_chromeos.h" 5 #include "device/bluetooth/bluetooth_adapter_profile_chromeos.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
11 #include "base/strings/string_util.h" 11 #include "base/strings/string_util.h"
12 #include "chromeos/dbus/bluetooth_profile_service_provider.h" 12 #include "chromeos/dbus/bluetooth_profile_service_provider.h"
13 #include "chromeos/dbus/dbus_thread_manager.h" 13 #include "chromeos/dbus/dbus_thread_manager.h"
14 #include "dbus/bus.h" 14 #include "dbus/bus.h"
15 #include "dbus/object_path.h" 15 #include "dbus/object_path.h"
16 #include "device/bluetooth/bluetooth_adapter_chromeos.h" 16 #include "device/bluetooth/bluetooth_adapter_chromeos.h"
17 #include "device/bluetooth/bluetooth_uuid.h" 17 #include "device/bluetooth/bluetooth_uuid.h"
18 18
19 namespace chromeos { 19 namespace chromeos {
20 20
21 // static 21 // static
22 BluetoothAdapterProfileChromeOS* BluetoothAdapterProfileChromeOS::Register( 22 void BluetoothAdapterProfileChromeOS::Register(
23 BluetoothAdapterChromeOS* adapter,
24 const device::BluetoothUUID& uuid, 23 const device::BluetoothUUID& uuid,
25 const BluetoothProfileManagerClient::Options& options, 24 const BluetoothProfileManagerClient::Options& options,
26 const base::Closure& success_callback, 25 const ProfileRegisteredCallback& success_callback,
27 const BluetoothProfileManagerClient::ErrorCallback& error_callback) { 26 const BluetoothProfileManagerClient::ErrorCallback& error_callback) {
28 DCHECK(adapter); 27 scoped_ptr<BluetoothAdapterProfileChromeOS> profile(
29 28 new BluetoothAdapterProfileChromeOS(uuid));
30 BluetoothAdapterProfileChromeOS* profile =
31 new BluetoothAdapterProfileChromeOS(adapter, uuid);
32 29
33 VLOG(1) << "Registering profile: " << profile->object_path().value(); 30 VLOG(1) << "Registering profile: " << profile->object_path().value();
34 DBusThreadManager::Get()->GetBluetoothProfileManagerClient()->RegisterProfile( 31 DBusThreadManager::Get()->GetBluetoothProfileManagerClient()->RegisterProfile(
35 profile->object_path(), uuid.canonical_value(), options, success_callback, 32 profile->object_path(),
33 uuid.canonical_value(),
34 options,
35 base::Bind(success_callback, base::Passed(&profile)),
36 error_callback); 36 error_callback);
37
38 return profile;
39 } 37 }
40 38
41 BluetoothAdapterProfileChromeOS::BluetoothAdapterProfileChromeOS( 39 BluetoothAdapterProfileChromeOS::BluetoothAdapterProfileChromeOS(
42 BluetoothAdapterChromeOS* adapter,
43 const device::BluetoothUUID& uuid) 40 const device::BluetoothUUID& uuid)
44 : uuid_(uuid), adapter_(adapter), weak_ptr_factory_(this) { 41 : uuid_(uuid), weak_ptr_factory_(this) {
45 std::string uuid_path; 42 std::string uuid_path;
46 base::ReplaceChars(uuid.canonical_value(), ":-", "_", &uuid_path); 43 base::ReplaceChars(uuid.canonical_value(), ":-", "_", &uuid_path);
47 object_path_ = 44 object_path_ =
48 dbus::ObjectPath("/org/chromium/bluetooth_profile/" + uuid_path); 45 dbus::ObjectPath("/org/chromium/bluetooth_profile/" + uuid_path);
49 46
50 dbus::Bus* system_bus = DBusThreadManager::Get()->GetSystemBus(); 47 dbus::Bus* system_bus = DBusThreadManager::Get()->GetSystemBus();
51 profile_.reset( 48 profile_.reset(
52 BluetoothProfileServiceProvider::Create(system_bus, object_path_, this)); 49 BluetoothProfileServiceProvider::Create(system_bus, object_path_, this));
53 DCHECK(profile_.get()); 50 DCHECK(profile_.get());
54 } 51 }
55 52
56 BluetoothAdapterProfileChromeOS::~BluetoothAdapterProfileChromeOS() { 53 BluetoothAdapterProfileChromeOS::~BluetoothAdapterProfileChromeOS() {
57 profile_.reset();
58 } 54 }
59 55
60 bool BluetoothAdapterProfileChromeOS::SetDelegate( 56 bool BluetoothAdapterProfileChromeOS::SetDelegate(
61 const dbus::ObjectPath& device_path, 57 const dbus::ObjectPath& device_path,
62 BluetoothProfileServiceProvider::Delegate* delegate) { 58 BluetoothProfileServiceProvider::Delegate* delegate) {
63 DCHECK(delegate); 59 DCHECK(delegate);
64 VLOG(1) << "SetDelegate: " << object_path_.value() << " dev " 60 VLOG(1) << "SetDelegate: " << object_path_.value() << " dev "
65 << device_path.value(); 61 << device_path.value();
66 62
67 if (delegates_.find(device_path.value()) != delegates_.end()) { 63 if (delegates_.find(device_path.value()) != delegates_.end()) {
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 // Cancel() should only go to a delegate accepting connections. 152 // Cancel() should only go to a delegate accepting connections.
157 if (delegates_.find("") == delegates_.end()) { 153 if (delegates_.find("") == delegates_.end()) {
158 VLOG(1) << object_path_.value() << ": Cancel with no delegate!"; 154 VLOG(1) << object_path_.value() << ": Cancel with no delegate!";
159 return; 155 return;
160 } 156 }
161 157
162 delegates_[""]->Cancel(); 158 delegates_[""]->Cancel();
163 } 159 }
164 160
165 } // namespace chromeos 161 } // namespace chromeos
OLDNEW
« no previous file with comments | « device/bluetooth/bluetooth_adapter_profile_chromeos.h ('k') | device/bluetooth/bluetooth_adapter_profile_chromeos_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698