Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 982563003: work around remove deps test failure (Closed)

Created:
5 years, 9 months ago by Jennifer Messerly
Modified:
5 years, 9 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

work around remove deps test failure mysterious that I'm the only one seeing this :) R=sigmund@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/f953d08d710263ed78d4a163329b4222f1a05ffe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M test/dependency_graph_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jennifer Messerly
5 years, 9 months ago (2015-03-04 18:24:56 UTC) #2
Siggi Cherem (dart-lang)
thanks, so wacky
5 years, 9 months ago (2015-03-04 18:32:05 UTC) #3
Siggi Cherem (dart-lang)
and that means LGTM
5 years, 9 months ago (2015-03-04 18:32:15 UTC) #4
Jennifer Messerly
Committed patchset #1 (id:1) manually as f953d08d710263ed78d4a163329b4222f1a05ffe (presubmit successful).
5 years, 9 months ago (2015-03-04 18:33:59 UTC) #5
Siggi Cherem (dart-lang)
5 years, 9 months ago (2015-03-05 00:12:52 UTC) #6
Message was sent while issue was closed.
Here is the vm bug explaining why I didn't hit it with the latest vm:
https://code.google.com/p/dart/issues/detail?id=22668

Powered by Google App Engine
This is Rietveld 408576698