runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart - Issue 98253009: Refactor VM service IDs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart

Issue 98253009: Refactor VM service IDs (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/client/lib/src/observatory_elements/function_view.html ('k') | runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.html » ('j') | runtime/vm/object.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart

diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart b/runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart

index 3e8aa78337ce369644a475fff09adc9fe5e88c26..7f5368fde62ea5962fb73b7cacb33c3134887d4e 100644

--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart

+++ b/runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.dart

@@ -5,10 +5,16 @@

library instance_ref_element;

import 'package:polymer/polymer.dart';

-import 'observatory_element.dart';

+import 'service_ref.dart';

@CustomTag('instance-ref')

-class InstanceRefElement extends ObservatoryElement {

- @published Map instance;

+class InstanceRefElement extends ServiceRefElement {

InstanceRefElement.created() : super.created();

+ String get name {

+ if (ref == null) {

+ return super.name;

+ }

+ return ref['preview'];

+ }

}