Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 982523004: Add script to view URL in HTMLViewer (Closed)

Created:
5 years, 9 months ago by blundell
Modified:
5 years, 9 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, sky, DaveMoore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add script to view URL in HTMLViewer This script takes advantage of the fact that Mojo binaries are published in the cloud to add functionality for viewing a URL in HTMLViewer embedded in the kiosk window manager. Committed: https://crrev.com/fe3f7ae8eb9390a4fe3f59e6244d4bbd6af7a9cd Cr-Commit-Position: refs/heads/master@{#319085}

Patch Set 1 #

Patch Set 2 : Remove unneeded imports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -0 lines) Patch
A mojo/services/html_viewer/view_url.py View 1 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
blundell
5 years, 9 months ago (2015-03-04 16:37:24 UTC) #2
blundell
To be clear, this script is just for developer convenience.
5 years, 9 months ago (2015-03-04 16:43:55 UTC) #3
jamesr
Seems pretty handy - I'll wager Dave and Scott will get use out of this ...
5 years, 9 months ago (2015-03-04 17:24:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/982523004/20001
5 years, 9 months ago (2015-03-04 17:59:06 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-04 18:22:42 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 18:26:30 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fe3f7ae8eb9390a4fe3f59e6244d4bbd6af7a9cd
Cr-Commit-Position: refs/heads/master@{#319085}

Powered by Google App Engine
This is Rietveld 408576698