Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart

Issue 982513004: Replace use of runtime type with name of the node in the CPS IrTracer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
index 448210697508567eaf96f77b1d8a58222fafbb2d..4f483fe3fedc375c7ff80627f35cb1b5467c19c7 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
@@ -148,7 +148,7 @@ class IRTracer extends TracerUtil implements cps_ir.Visitor {
visitLetMutable(cps_ir.LetMutable node) {
String id = names.name(node.variable);
- printStmt(id, "${node.runtimeType} $id = ${formatReference(node.value)}");
+ printStmt(id, "LetMutable $id = ${formatReference(node.value)}");
visit(node.body);
}
@@ -244,7 +244,7 @@ class IRTracer extends TracerUtil implements cps_ir.Visitor {
String dummy = names.name(node);
String variable = names.name(node.variable.definition);
String value = formatReference(node.value);
- printStmt(dummy, '${node.runtimeType} $variable := $value');
+ printStmt(dummy, 'SetMutableVariable $variable := $value');
visit(node.body);
}
@@ -275,7 +275,7 @@ class IRTracer extends TracerUtil implements cps_ir.Visitor {
}
visitMutableVariable(cps_ir.MutableVariable node) {
- return "${node.runtimeType} ${names.name(node)}";
+ return "MutableVariable ${names.name(node)}";
}
visitContinuation(cps_ir.Continuation node) {
@@ -335,7 +335,7 @@ class IRTracer extends TracerUtil implements cps_ir.Visitor {
visitGetMutableVariable(cps_ir.GetMutableVariable node) {
String variable = names.name(node.variable.definition);
- return '${node.runtimeType} $variable';
+ return 'GetMutableVariable $variable';
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698