Issue 982473002: Add more instrumentation for tracking jank in ProxyService creation.

Issue 982473002: Add more instrumentation for tracking jank in ProxyService creation. (Closed)

Created:
5 years, 9 months ago by eroman

Modified:
5 years, 9 months ago

Reviewers:
michaeln, Peter Kasting

CC:
chromium-reviews, cbentzel+watch_chromium.org, Peter Kasting

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Add more instrumentation for tracking jank in ProxyService creation. BUG=454983 Committed: https://crrev.com/fe30254f90c8884072816c502b225f4e15b594d9 Cr-Commit-Position: refs/heads/master@{#319188}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
	M	net/proxy/proxy_config_service_win.cc	View	1 2	2 chunks	+7 lines, -1 line	0 comments	Download
	M	net/proxy/proxy_service.cc	View	1 2	2 chunks	+8 lines, -0 lines	0 comments	Download

Total messages: 12 (4 generated)

Peter Kasting

Nit: Please add TODOs above each of these places saying that they are temporary and ...

5 years, 9 months ago (2015-03-04 23:09:20 UTC) #6

eroman

> Nit: Please add TODOs above each of these places say Done

5 years, 9 months ago (2015-03-05 00:20:40 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/982473002/40001

5 years, 9 months ago (2015-03-05 00:21:07 UTC) #10

commit-bot: I haz the power

5 years, 9 months ago (2015-03-05 01:15:33 UTC) #12

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/fe30254f90c8884072816c502b225f4e15b594d9
Cr-Commit-Position: refs/heads/master@{#319188}