Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 982413003: cc: Disable more mask pixel tests on Windows (Closed)

Created:
5 years, 9 months ago by enne (OOO)
Modified:
5 years, 9 months ago
Reviewers:
danakj
CC:
cc-bugs_chromium.org, chromium-reviews, Lof, Lei Zhang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Disable more mask pixel tests on Windows BUG=435632, 464859 Committed: https://crrev.com/fe701878f920c056109446688dde581b1d5331fb Cr-Commit-Position: refs/heads/master@{#319541}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move ifdefs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M cc/trees/layer_tree_host_pixeltest_masks.cc View 1 4 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
enne (OOO)
5 years, 9 months ago (2015-03-06 22:23:22 UTC) #2
danakj
Do you have an idea what is too slow here? I don't see it in ...
5 years, 9 months ago (2015-03-06 22:32:12 UTC) #3
danakj
https://codereview.chromium.org/982413003/diff/1/cc/trees/layer_tree_host_pixeltest_masks.cc File cc/trees/layer_tree_host_pixeltest_masks.cc (right): https://codereview.chromium.org/982413003/diff/1/cc/trees/layer_tree_host_pixeltest_masks.cc#newcode61 cc/trees/layer_tree_host_pixeltest_masks.cc:61: #if !defined(OS_WIN) might as well move this up by ...
5 years, 9 months ago (2015-03-06 22:32:57 UTC) #4
enne (OOO)
PTAL I just suspect that these tests do more raster work / GPU work than ...
5 years, 9 months ago (2015-03-06 22:38:24 UTC) #5
danakj
LGTM
5 years, 9 months ago (2015-03-06 22:39:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/982413003/20001
5 years, 9 months ago (2015-03-06 22:41:51 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 00:44:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/982413003/20001
5 years, 9 months ago (2015-03-07 00:45:50 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-07 01:22:50 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-07 01:23:56 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fe701878f920c056109446688dde581b1d5331fb
Cr-Commit-Position: refs/heads/master@{#319541}

Powered by Google App Engine
This is Rietveld 408576698