remoting/signaling/xmpp_signal_strategy.cc - Issue 982413002: base: Stop passing a non-const ref to ObserverListBase::Iterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/signaling/xmpp_signal_strategy.cc

Issue 982413002: base: Stop passing a non-const ref to ObserverListBase::Iterator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: observerref: fixwindowsbuild Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/signaling/xmpp_signal_strategy.cc

diff --git a/remoting/signaling/xmpp_signal_strategy.cc b/remoting/signaling/xmpp_signal_strategy.cc

index 5ad0c039abdfcb8e6577a937c4bf24bbccaa5a40..f2d7b813713bc13b5b7498f2910e73b33b462cd6 100644

--- a/remoting/signaling/xmpp_signal_strategy.cc

+++ b/remoting/signaling/xmpp_signal_strategy.cc

@@ -193,7 +193,7 @@ std::string XmppSignalStrategy::GetNextId() {

bool XmppSignalStrategy::HandleStanza(const buzz::XmlElement* stanza) {

DCHECK(CalledOnValidThread());

- ObserverListBase<Listener>::Iterator it(listeners_);

+ ObserverListBase<Listener>::Iterator it(&listeners_);

Listener* listener;

while ((listener = it.GetNext()) != nullptr) {

if (listener->OnSignalStrategyIncomingStanza(stanza))

« no previous file with comments | « remoting/signaling/fake_signal_strategy.cc ('k') | ui/aura/window.cc » ('j') | no next file with comments »