content/renderer/render_view_impl.cc - Issue 982413002: base: Stop passing a non-const ref to ObserverListBase::Iterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 982413002: base: Stop passing a non-const ref to ObserverListBase::Iterator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: observerref: fixwindowsbuild Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index 3eee7b2993efcde98a5084943bdbfd8cf227c9bf..8a260b10a364d3e22397c913d5a73d67dcac8203 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -1269,7 +1269,7 @@ bool RenderViewImpl::OnMessageReceived(const IPC::Message& message) {

if (main_frame && main_frame->isWebLocalFrame())

GetContentClient()->SetActiveURL(main_frame->document().url());

- ObserverListBase<RenderViewObserver>::Iterator it(observers_);

+ ObserverListBase<RenderViewObserver>::Iterator it(&observers_);

RenderViewObserver* observer;

while ((observer = it.GetNext()) != NULL)

if (observer->OnMessageReceived(message))

« no previous file with comments | « content/renderer/render_thread_impl.cc ('k') | ipc/ipc_test_sink.cc » ('j') | no next file with comments »