content/renderer/render_frame_impl.cc - Issue 982413002: base: Stop passing a non-const ref to ObserverListBase::Iterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 982413002: base: Stop passing a non-const ref to ObserverListBase::Iterator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: observerref: fixwindowsbuild Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index 3e4317cb0cbaff6cbc8d6b50a8e16408c2184dfe..9fc02b7a593fb7d0d347efd1fab294044ccb573e 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -959,7 +959,7 @@ bool RenderFrameImpl::OnMessageReceived(const IPC::Message& msg) {

if (!frame_->document().isNull())

GetContentClient()->SetActiveURL(frame_->document().url());

- ObserverListBase<RenderFrameObserver>::Iterator it(observers_);

+ ObserverListBase<RenderFrameObserver>::Iterator it(&observers_);

RenderFrameObserver* observer;

while ((observer = it.GetNext()) != NULL) {

if (observer->OnMessageReceived(msg))

« no previous file with comments | « content/public/test/mock_render_thread.cc ('k') | content/renderer/render_thread_impl.cc » ('j') | no next file with comments »