content/browser/web_contents/web_contents_impl.cc - Issue 982413002: base: Stop passing a non-const ref to ObserverListBase::Iterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 982413002: base: Stop passing a non-const ref to ObserverListBase::Iterator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: observerref: fixwindowsbuild Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index e56e327c7d163be0dddcbfba4fd4a4e2b58f75aa..1c917e52fed0ffd51ab3b84fd265e1cf3b0cb604 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -509,7 +509,7 @@ bool WebContentsImpl::OnMessageReceived(RenderViewHost* render_view_host,

return true;

}

- ObserverListBase<WebContentsObserver>::Iterator it(observers_);

+ ObserverListBase<WebContentsObserver>::Iterator it(&observers_);

WebContentsObserver* observer;

if (render_frame_host) {

while ((observer = it.GetNext()) != NULL)

« no previous file with comments | « content/browser/service_worker/embedded_worker_instance.cc ('k') | content/public/test/mock_render_thread.cc » ('j') | no next file with comments »