content/browser/loader/resource_dispatcher_host_impl.cc - Issue 982413002: base: Stop passing a non-const ref to ObserverListBase::Iterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.cc

Issue 982413002: base: Stop passing a non-const ref to ObserverListBase::Iterator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: observerref: fixwindowsbuild Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/renderer_context_menu/render_view_context_menu_base.cc ('k') | content/browser/service_worker/embedded_worker_instance.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/resource_dispatcher_host_impl.cc

diff --git a/content/browser/loader/resource_dispatcher_host_impl.cc b/content/browser/loader/resource_dispatcher_host_impl.cc

index c1b6b740bf489ba6fe7cc7d05eaf5382918f1372..94d816baa848499f5d774f6ba1537e0b8d7080de 100644

--- a/content/browser/loader/resource_dispatcher_host_impl.cc

+++ b/content/browser/loader/resource_dispatcher_host_impl.cc

@@ -957,7 +957,7 @@ bool ResourceDispatcherHostImpl::OnMessageReceived(

GlobalRequestID id(filter_->child_id(), request_id);

DelegateMap::iterator it = delegate_map_.find(id);

if (it != delegate_map_.end()) {

- ObserverList<ResourceMessageDelegate>::Iterator del_it(*it->second);

+ ObserverList<ResourceMessageDelegate>::Iterator del_it(it->second);

ResourceMessageDelegate* delegate;

while (!handled && (delegate = del_it.GetNext()) != NULL) {

handled = delegate->OnMessageReceived(message);

@@ -1060,7 +1060,7 @@ void ResourceDispatcherHostImpl::UpdateRequestForTransfer(

DelegateMap::iterator it = delegate_map_.find(old_request_id);

if (it != delegate_map_.end()) {

// Tell each delegate that the request ID has changed.

- ObserverList<ResourceMessageDelegate>::Iterator del_it(*it->second);

+ ObserverList<ResourceMessageDelegate>::Iterator del_it(it->second);

ResourceMessageDelegate* delegate;

while ((delegate = del_it.GetNext()) != NULL) {

delegate->set_request_id(new_request_id);