chrome/browser/extensions/extension_toolbar_model.cc - Issue 982413002: base: Stop passing a non-const ref to ObserverListBase::Iterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_toolbar_model.cc

Issue 982413002: base: Stop passing a non-const ref to ObserverListBase::Iterator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: observerref: fixwindowsbuild Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « cc/animation/layer_animation_controller.cc ('k') | components/renderer_context_menu/render_view_context_menu_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_toolbar_model.cc

diff --git a/chrome/browser/extensions/extension_toolbar_model.cc b/chrome/browser/extensions/extension_toolbar_model.cc

index e5a05cb17437b52e0e08151799467d5e9866e602..c89d16c443f06842922bed8453212ae7d0b25aff 100644

--- a/chrome/browser/extensions/extension_toolbar_model.cc

+++ b/chrome/browser/extensions/extension_toolbar_model.cc

@@ -655,7 +655,7 @@ bool ExtensionToolbarModel::ShowExtensionActionPopup(

const Extension* extension,

Browser* browser,

bool grant_active_tab) {

- ObserverListBase<Observer>::Iterator it(observers_);

+ ObserverListBase<Observer>::Iterator it(&observers_);

Observer* obs = NULL;

// Look for the Observer associated with the browser.

// This would be cleaner if we had an abstract class for the Toolbar UI

« no previous file with comments | « cc/animation/layer_animation_controller.cc ('k') | components/renderer_context_menu/render_view_context_menu_base.cc » ('j') | no next file with comments »