base/prefs/pref_notifier_impl_unittest.cc - Issue 982413002: base: Stop passing a non-const ref to ObserverListBase::Iterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/prefs/pref_notifier_impl_unittest.cc

Issue 982413002: base: Stop passing a non-const ref to ObserverListBase::Iterator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: observerref: fixwindowsbuild Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/prefs/pref_notifier_impl_unittest.cc

diff --git a/base/prefs/pref_notifier_impl_unittest.cc b/base/prefs/pref_notifier_impl_unittest.cc

index 0ecf138d17599d9a4d5d00087ff2c4ea2307d926..c3cbf4f48c1964724f23104b775e664ef45adca5 100644

--- a/base/prefs/pref_notifier_impl_unittest.cc

+++ b/base/prefs/pref_notifier_impl_unittest.cc

@@ -58,7 +58,7 @@ class MockPrefNotifier : public PrefNotifierImpl {

return false;

PrefObserverList* observer_list = observer_iterator->second;

- PrefObserverList::Iterator it(*observer_list);

+ PrefObserverList::Iterator it(observer_list);

PrefObserver* existing_obs;

size_t count = 0;

while ((existing_obs = it.GetNext()) != NULL) {

« no previous file with comments | « base/prefs/pref_notifier_impl.cc ('k') | cc/animation/layer_animation_controller.cc » ('j') | no next file with comments »