Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Side by Side Diff: content/renderer/render_thread_impl.cc

Issue 982413002: base: Stop passing a non-const ref to ObserverListBase::Iterator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: observerref: fixwindowsbuild Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_thread_impl.h" 5 #include "content/renderer/render_thread_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <limits> 8 #include <limits>
9 #include <map> 9 #include <map>
10 #include <vector> 10 #include <vector>
(...skipping 1472 matching lines...) Expand 10 before | Expand all | Expand 10 after
1483 1483
1484 void RenderThreadImpl::DoNotSuspendWebKitSharedTimer() { 1484 void RenderThreadImpl::DoNotSuspendWebKitSharedTimer() {
1485 suspend_webkit_shared_timer_ = false; 1485 suspend_webkit_shared_timer_ = false;
1486 } 1486 }
1487 1487
1488 void RenderThreadImpl::DoNotNotifyWebKitOfModalLoop() { 1488 void RenderThreadImpl::DoNotNotifyWebKitOfModalLoop() {
1489 notify_webkit_of_modal_loop_ = false; 1489 notify_webkit_of_modal_loop_ = false;
1490 } 1490 }
1491 1491
1492 bool RenderThreadImpl::OnControlMessageReceived(const IPC::Message& msg) { 1492 bool RenderThreadImpl::OnControlMessageReceived(const IPC::Message& msg) {
1493 ObserverListBase<RenderProcessObserver>::Iterator it(observers_); 1493 ObserverListBase<RenderProcessObserver>::Iterator it(&observers_);
1494 RenderProcessObserver* observer; 1494 RenderProcessObserver* observer;
1495 while ((observer = it.GetNext()) != NULL) { 1495 while ((observer = it.GetNext()) != NULL) {
1496 if (observer->OnControlMessageReceived(msg)) 1496 if (observer->OnControlMessageReceived(msg))
1497 return true; 1497 return true;
1498 } 1498 }
1499 1499
1500 // Some messages are handled by delegates. 1500 // Some messages are handled by delegates.
1501 if (appcache_dispatcher_->OnMessageReceived(msg) || 1501 if (appcache_dispatcher_->OnMessageReceived(msg) ||
1502 dom_storage_dispatcher_->OnMessageReceived(msg) || 1502 dom_storage_dispatcher_->OnMessageReceived(msg) ||
1503 embedded_worker_dispatcher_->OnMessageReceived(msg)) { 1503 embedded_worker_dispatcher_->OnMessageReceived(msg)) {
(...skipping 325 matching lines...) Expand 10 before | Expand all | Expand 10 after
1829 mojo::InterfaceRequest<mojo::ServiceProvider> services, 1829 mojo::InterfaceRequest<mojo::ServiceProvider> services,
1830 mojo::ServiceProviderPtr exposed_services) 1830 mojo::ServiceProviderPtr exposed_services)
1831 : services(services.Pass()), 1831 : services(services.Pass()),
1832 exposed_services(exposed_services.Pass()) { 1832 exposed_services(exposed_services.Pass()) {
1833 } 1833 }
1834 1834
1835 RenderThreadImpl::PendingRenderFrameConnect::~PendingRenderFrameConnect() { 1835 RenderThreadImpl::PendingRenderFrameConnect::~PendingRenderFrameConnect() {
1836 } 1836 }
1837 1837
1838 } // namespace content 1838 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698