Subzero: Switch file reading to be based on a DataStreamer and MemoryObject.

Subzero: Switch file reading to be based on a DataStreamer and MemoryObject.

This makes it compatible with the current browser interface,
which pushes bytes to a DataStreamer.

In the browser-integration mode, there will be a push-based
DataStreamer (vs a file-based one).

BUG= https://code.google.com/p/nativeclient/issues/detail?id=4091
R=dschuff@chromium.org, kschimpf@google.com, stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=c1f07ea7fbeb4a9de30059c6ca5f0662eb0b1c7d

[jvoung (off chromium), 2015-03-06 21:47:02]

jvoung@chromium.org changed reviewers:
+ dschuff@chromium.org, kschimpf@google.com, stichnot@chromium.org

[Derek Schuff, 2015-03-06 21:56:05]

https://codereview.chromium.org/982403002/diff/20001/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/982403002/diff/20001/src/PNaClTranslator.cpp#...
src/PNaClTranslator.cpp:2995: void PNaClTranslator::translateBuffer(const
std::string &IRFilename,
so is translatebuffer still used now that it's not used by translate()?

[Karl, 2015-03-06 22:04:19]

LGTM other than removing translateBuffer?

[Jim Stichnoth, 2015-03-06 22:31:23]

also lgtm

[jvoung (off chromium), 2015-03-06 22:34:54]

https://codereview.chromium.org/982403002/diff/20001/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/982403002/diff/20001/src/PNaClTranslator.cpp#...
src/PNaClTranslator.cpp:2995: void PNaClTranslator::translateBuffer(const
std::string &IRFilename,
On 2015/03/06 21:56:05, Derek Schuff wrote:
> so is translatebuffer still used now that it's not used by translate()?

translateBuffer is being used by:

subzero/unittest/BitcodeMunge.cpp:  Translator.translateBuffer(TestName,
MungedInput.get());

[Derek Schuff, 2015-03-06 22:39:39]

lgtm

[jvoung (off chromium), 2015-03-06 22:53:35]

Committed patchset #2 (id:20001) manually as
c1f07ea7fbeb4a9de30059c6ca5f0662eb0b1c7d (presubmit successful).