Rendezvous to hung browser will again offer to kill it.

Rendezvous to hung browser will again offer to kill it.

BUG=464733
Committed: https://crrev.com/cacc15fbab42e79e18b745093204097dcd04ec6b
Cr-Commit-Position: refs/heads/master@{#319465}

[Sigurður Ásgeirsson, 2015-03-06 16:29:37]

siggi@chromium.org changed reviewers:
+ asvitkine@chromium.org, erikwright@chromium.org, thakis@chromium.org

[Sigurður Ásgeirsson, 2015-03-06 16:29:38]

Hey guys,

this fixes a ~20 month old regression and instruments the
rendezvous-to-hung-browser path.
I suspect this is hitting ~3.5% of users on canary in a given day. If this is
indeed the case, the next step is to figure out how this is happening by
systemically dumping core on those hung browsers.

Siggi

[Nico, 2015-03-06 16:30:57]

is it possible to test this so that it doesn't break again?

[Sigurður Ásgeirsson, 2015-03-06 16:34:24]

I'm sure it's possible to test some part of this, but IMHO the only
reasonable protection against regressions here is instrumentation and
metrics.
I'll work on a test, but in the meantime I'd very much like to land this
today so that there'll be some data to go from after the weekend - if you
don't mind?

On Fri, Mar 6, 2015 at 11:30 AM <thakis@chromium.org> wrote:

> is it possible to test this so that it doesn't break again?
>
> https://codereview.chromium.org/982323002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2015-03-06 17:29:41]

ok, lgtm

But I'm worried that this is some heroic one-time effort, your metric will go to
where you want it to go, you'll declare victory, and due to lack of testing it
then creeps back to badness.

[Alexei Svitkine (slow), 2015-03-06 17:30:57]

lgtm, though I echo Nico's concerns.

[Sigurður Ásgeirsson, 2015-03-06 17:56:32]

The CQ bit was checked by siggi@chromium.org

[Sigurður Ásgeirsson, 2015-03-06 17:57:26]

On 2015/03/06 17:30:57, Alexei Svitkine wrote:
> lgtm, though I echo Nico's concerns.

Thanks guys - I'm working on a test as we speak.

[commit-bot: I haz the power, 2015-03-06 17:58:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/982323002/1

[commit-bot: I haz the power, 2015-03-06 18:16:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-06 18:17:40]

Patchset 1 (id:??) landed as
https://crrev.com/cacc15fbab42e79e18b745093204097dcd04ec6b
Cr-Commit-Position: refs/heads/master@{#319465}