Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Issue 982293002: Remove --pretty-print-prefs switch. (Closed)

Created:
5 years, 9 months ago by gab
Modified:
5 years, 9 months ago
Reviewers:
Bernhard Bauer, Nico
CC:
chromium-reviews, erikwright+watch_chromium.org, hashimoto
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove --pretty-print-prefs switch. It can be replaced by command-line or online JSON pretty-printing tools when needed. This is a follow-up to the discussion @ https://groups.google.com/a/chromium.org/d/topic/chromium-dev/zFpKtSBKKoc/discussion BUG=463366 Committed: https://crrev.com/97c50ace3ee858cdd15aac5631a62d6d5a198415 Cr-Commit-Position: refs/heads/master@{#319493}

Patch Set 1 #

Patch Set 2 : tweak comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -37 lines) Patch
M base/BUILD.gn View 2 chunks +1 line, -3 lines 0 comments Download
M base/base.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D base/prefs/base_prefs_switches.h View 1 chunk +0 lines, -14 lines 0 comments Download
D base/prefs/base_prefs_switches.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M base/prefs/json_pref_store.cc View 1 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
gab
Nico PTAL, more or less a revert of part of https://codereview.chromium.org/974753002. (and Bernhard, but looks ...
5 years, 9 months ago (2015-03-06 12:52:19 UTC) #3
Nico
On 2015/03/06 12:52:19, gab wrote: > Nico PTAL, more or less a revert of part ...
5 years, 9 months ago (2015-03-06 15:41:34 UTC) #4
gab
On 2015/03/06 15:41:34, Nico wrote: > On 2015/03/06 12:52:19, gab wrote: > > Nico PTAL, ...
5 years, 9 months ago (2015-03-06 15:56:34 UTC) #5
gab
On 2015/03/06 15:56:34, gab wrote: > On 2015/03/06 15:41:34, Nico wrote: > > On 2015/03/06 ...
5 years, 9 months ago (2015-03-06 15:57:24 UTC) #6
Bernhard Bauer
LGTM On 2015/03/06 15:56:34, gab wrote: > On 2015/03/06 15:41:34, Nico wrote: > > On ...
5 years, 9 months ago (2015-03-06 16:56:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/982293002/20001
5 years, 9 months ago (2015-03-06 17:04:05 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-06 20:41:51 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 20:42:46 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/97c50ace3ee858cdd15aac5631a62d6d5a198415
Cr-Commit-Position: refs/heads/master@{#319493}

Powered by Google App Engine
This is Rietveld 408576698