Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: device/media_transfer_protocol/media_transfer_protocol_daemon_client.cc

Issue 982283002: Implement DeleteFile and DeleteDirectory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix failed test case. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/media_transfer_protocol/media_transfer_protocol_daemon_client.cc
diff --git a/device/media_transfer_protocol/media_transfer_protocol_daemon_client.cc b/device/media_transfer_protocol/media_transfer_protocol_daemon_client.cc
index 2dddbce4c1916f45b47e8395428858712a194e14..832d5984e64980789f032676f0b374dcf90ffc45 100644
--- a/device/media_transfer_protocol/media_transfer_protocol_daemon_client.cc
+++ b/device/media_transfer_protocol/media_transfer_protocol_daemon_client.cc
@@ -193,6 +193,20 @@ class MediaTransferProtocolDaemonClientImpl
weak_ptr_factory_.GetWeakPtr(), callback, error_callback));
}
+ void DeleteObject(const std::string& handle,
+ const uint32 object_id,
+ const DeleteObjectCallback& callback,
+ const ErrorCallback& error_callback) override {
+ dbus::MethodCall method_call(mtpd::kMtpdInterface, mtpd::kDeleteObject);
+ dbus::MessageWriter writer(&method_call);
+ writer.AppendString(handle);
+ writer.AppendUint32(object_id);
+ proxy_->CallMethod(
+ &method_call, dbus::ObjectProxy::TIMEOUT_USE_DEFAULT,
+ base::Bind(&MediaTransferProtocolDaemonClientImpl::OnDeleteObject,
+ weak_ptr_factory_.GetWeakPtr(), callback, error_callback));
+ }
+
// MediaTransferProtocolDaemonClient override.
void ListenForChanges(const MTPStorageEventHandler& handler) override {
DCHECK(!listen_for_changes_called_);
@@ -382,6 +396,17 @@ class MediaTransferProtocolDaemonClientImpl
callback.Run();
}
+ void OnDeleteObject(const DeleteObjectCallback& callback,
+ const ErrorCallback& error_callback,
+ dbus::Response* response) {
+ if (!response) {
+ error_callback.Run();
+ return;
+ }
+
+ callback.Run();
+ }
+
// Handles MTPStorageAttached/Dettached signals and calls |handler|.
void OnMTPStorageSignal(MTPStorageEventHandler handler,
bool is_attach,

Powered by Google App Engine
This is Rietveld 408576698