Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 982273002: Sync the Touch-related interfaces with the two specs (Closed)

Created:
5 years, 9 months ago by philipj_slow
Modified:
5 years, 9 months ago
Reviewers:
Rick Byers
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync the Touch-related interfaces with the two specs Unfortunately there does not appear to be a single well-maintained spec that deals with all of this, but these documents from the Touch Events Community Group seem to be the most recently updated: http://rawgit.com/w3c/touch-events/v1-errata/touchevents.html http://rawgit.com/w3c/touch-events/master/touchevents.html There are no changes to the generated code except for changes in order. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191441

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -16 lines) Patch
M Source/core/dom/Document.idl View 1 chunk +1 line, -1 line 2 comments Download
M Source/core/dom/Touch.idl View 1 chunk +20 lines, -11 lines 0 comments Download
M Source/core/dom/TouchList.idl View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/events/TouchEvent.idl View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
philipj_slow
PTAL. As you can tell I couldn't find a good spec when I added a ...
5 years, 9 months ago (2015-03-06 08:16:36 UTC) #2
Rick Byers
Thanks LGTM. Yeah we don't currently have a WG working on a new official version ...
5 years, 9 months ago (2015-03-06 13:56:55 UTC) #3
philipj_slow
Thanks for the follow-up to fix these, I'll leave this as-is to not introduce any ...
5 years, 9 months ago (2015-03-06 15:33:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/982273002/1
5 years, 9 months ago (2015-03-06 15:34:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=191441
5 years, 9 months ago (2015-03-06 15:37:49 UTC) #7
Rick Byers
On 2015/03/06 15:33:59, philipj_UTC7 wrote: > Thanks for the follow-up to fix these, I'll leave ...
5 years, 9 months ago (2015-03-06 15:53:14 UTC) #8
philipj_slow
5 years, 9 months ago (2015-03-06 17:15:17 UTC) #9
Message was sent while issue was closed.
On 2015/03/06 15:53:14, Rick Byers wrote:
> On 2015/03/06 15:33:59, philipj_UTC7 wrote:
> > Thanks for the follow-up to fix these, I'll leave this as-is to not
introduce
> > any behavior changes.
> 
> Ok, updated crbug.com/460099 to include changing the arg names.  In what
> scenarios might that be a "behavior change"?  Just when called from a language
> with named parameters, right?  I think we really care only about JavaScript
> bindings so this shouldn't be an issue (plus this API is quite obscure and
> rarely used).

Yes I'm just confused, changing the argument names wouldn't be an observable
change.

Powered by Google App Engine
This is Rietveld 408576698