Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 982203002: Autofill - Move test only code to a test util file. (Closed)

Created:
5 years, 9 months ago by Evan Stade
Modified:
5 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autofill - Move test only code to a test util file. BUG= Committed: https://crrev.com/9dade1d9260a7f2d8caae033535b2f7e21683478 Cr-Commit-Position: refs/heads/master@{#319456}

Patch Set 1 #

Patch Set 2 : add dcheck #

Total comments: 1

Patch Set 3 : include vector #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -50 lines) Patch
M components/autofill/core/browser/autofill_test_utils.h View 1 2 3 chunks +8 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_test_utils.cc View 1 2 chunks +20 lines, -0 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 1 9 chunks +26 lines, -23 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_table.cc View 1 2 chunks +1 line, -17 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_table_unittest.cc View 1 7 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
brettw
This is OK but my patch asserts if it finds an unmasked card in the ...
5 years, 9 months ago (2015-03-05 23:43:34 UTC) #2
Evan Stade
updated https://codereview.chromium.org/982203002/diff/20001/components/autofill/core/browser/personal_data_manager_unittest.cc File components/autofill/core/browser/personal_data_manager_unittest.cc (right): https://codereview.chromium.org/982203002/diff/20001/components/autofill/core/browser/personal_data_manager_unittest.cc#newcode2897 components/autofill/core/browser/personal_data_manager_unittest.cc:2897: EXPECT_EQ(ASCIIToUTF16("Bonnie Parker"), suggestions[1].value); suggestions changed order because unmasking ...
5 years, 9 months ago (2015-03-06 00:10:41 UTC) #3
brettw
lgtm
5 years, 9 months ago (2015-03-06 05:58:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/982203002/40001
5 years, 9 months ago (2015-03-06 15:14:46 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-06 16:46:01 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 16:46:28 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9dade1d9260a7f2d8caae033535b2f7e21683478
Cr-Commit-Position: refs/heads/master@{#319456}

Powered by Google App Engine
This is Rietveld 408576698